Conversation
--------- **Commit 1:** Don't try to delete index template along with pattern This commit reverts a change to use the ingest API when deleting index patterns via the Kibana UI. Back when I was building the Filebeat wizard it made sense to try to delete any index templates or pipelines that may have been created along with an index pattern. But now that we're only shipping with CSV Upload, and we don't delete the actual indices that CSV upload creates, it doesn't make much sense to delete the template. Now we'll treate the indices and templates consistently. This also fixes an issue where users would get a fatal error if they were using Security and they didn't have permissions to delete templates. Every index pattern deletion would also attempt to delete an associated template, so if the user didn't have the correct permissions they would get a 403. Related: #6457 * Original sha: daa5b3b * Authored by Matthew Bargar <mbargar@gmail.com> on 2016-09-20T22:43:03Z
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[backport] PR elastic#8391 to 5.x Former-commit-id: 8b7bfa7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport PR #8391
Commit 1:
Don't try to delete index template along with pattern
This commit reverts a change to use the ingest API when deleting index
patterns via the Kibana UI. Back when I was building the Filebeat wizard
it made sense to try to delete any index templates or pipelines that may
have been created along with an index pattern. But now that we're only
shipping with CSV Upload, and we don't delete the actual indices that
CSV upload creates, it doesn't make much sense to delete the template.
Now we'll treate the indices and templates consistently.
This also fixes an issue where users would get a fatal error if they
were using Security and they didn't have permissions to delete
templates. Every index pattern deletion would also attempt to delete an
associated template, so if the user didn't have the correct permissions
they would get a 403.
Related: #6457