Skip to content

Update dependency @elastic/charts to v24.2.0#84223

Merged
markov00 merged 1 commit intomasterfrom
renovate/@elasticcharts
Nov 30, 2020
Merged

Update dependency @elastic/charts to v24.2.0#84223
markov00 merged 1 commit intomasterfrom
renovate/@elasticcharts

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate bot commented Nov 24, 2020 •
edited
Loading

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@elastic/charts 24.0.0 -> 24.2.0 age adoption passing confidence

Release Notes

elastic/elastic-charts

v24.2.0

Compare Source

Bug Fixes
  • near and far alignments for orthogonal rotations (#​911) (cb279f3)
Features

v24.1.0

Compare Source

Bug Fixes
Features

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added release_note:skip Skip the PR/issue when compiling release notes renovate Renovate dependency update with major version updates Team:Operations Kibana-Operations Team v7.10.0 v8.0.0 labels Nov 24, 2020
@renovate renovate bot requested a review from markov00 November 24, 2020 14:55
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 24, 2020

Pinging @elastic/kibana-operations (Team:Operations)

nickofthyme
nickofthyme reviewed Nov 24, 2020
View reviewed changes
yarn.lock
Comment on lines 1403 to -1405
"@elastic/datemath@link:packages/elastic-datemath":
version "0.0.0"
uid ""
Copy link
Copy Markdown
Contributor

@nickofthyme nickofthyme Nov 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spalger is this expected? Seems a bit strange.

Copy link
Copy Markdown
Contributor

@spalger spalger Nov 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it seems that renovate isn't doing the right thing here, when I make a change to the yarn.lock file locally all those changes get reverted :/ I'll fix up this PR and file an issue with them.

@markov00
Copy link
Copy Markdown
Contributor

markov00 commented Nov 24, 2020

@elastic/kibana-operations what are all those changes at the yarn.lock file? Seems outside of the scope for this single dependency upgrade

@spalger
Copy link
Copy Markdown
Contributor

spalger commented Nov 24, 2020 •
edited
Loading

@nickofthyme @markov00 can we wait a little while before merging this to give the renovate folks a chance to debug these yarn.lock issues? Having this as a reproduction for my issue would be nice.

Issue: renovatebot/renovate#7806

@spalger spalger mentioned this pull request Nov 24, 2020
Closed
@markov00 markov00 mentioned this pull request Nov 25, 2020
Closed
10 tasks
@markov00
Copy link
Copy Markdown
Contributor

markov00 commented Nov 30, 2020

Hey @spalger I've seen Renovatebot folks have replyed, can we go on, rebase and merge?

@renovate renovate bot changed the title Update dependency @elastic/charts to v24.1.0 Update dependency @elastic/charts to v24.2.0 Nov 30, 2020
@renovate renovate bot force-pushed the renovate/@elasticcharts branch from 41bc4a9 to 4766577 Compare November 30, 2020 15:59
@spalger
Copy link
Copy Markdown
Contributor

spalger commented Nov 30, 2020

Looks like the renovate issue is fixed now, LGTM!

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Nov 30, 2020

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.1MB 3.1MB +81.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 547.1KB 546.8KB -360.0B
Unknown metric groups

@kbn/ui-shared-deps asset size

id before after diff
kbn-ui-shared-deps.@elastic.js 2.4MB 2.4MB +17.7KB
kbn-ui-shared-deps.js 13.6MB 13.6MB +22.0B
total +17.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

markov00
markov00 approved these changes Nov 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markov00 markov00 merged commit 647b991 into master Nov 30, 2020
@renovate renovate bot deleted the renovate/@elasticcharts branch November 30, 2020 17:44
@markov00 markov00 mentioned this pull request Nov 30, 2020
Merged
markov00 pushed a commit to markov00/kibana that referenced this pull request Nov 30, 2020
@renovate @renovate-bot @markov00
Update dependency @elastic/charts to v24.2.0 (elastic#84223)
be07708 
Co-authored-by: Renovate Bot <bot@renovateapp.com>
markov00 added a commit that referenced this pull request Dec 1, 2020
@markov00 @renovate @renovate-bot
Update dependency @elastic/charts to v24.2.0 (#84223) (#84560)
c511477 
Co-authored-by: Renovate Bot <bot@renovateapp.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
@mbondyra mbondyra mentioned this pull request Dec 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickofthyme nickofthyme nickofthyme left review comments

@markov00 markov00 markov00 approved these changes

+1 more reviewer

@spalger spalger spalger left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes renovate Renovate dependency update with major version updates Team:Operations Kibana-Operations Team v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@elasticmachine @markov00 @spalger @kibanamachine @nickofthyme @renovate-bot