[ILM] Relax POST policy route validation #84203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jloleysens
added
Feature:ILM
v8.0.0
Team:Kibana Management
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
yuliacech
approved these changes
Nov 24, 2020
Contributor
yuliacech
left a comment
yuliacech
left a comment
There was a problem hiding this comment.
Hi @jloleysens , I agree that maintaining the schema is not providing as much benefit as it costs the effort. Our (de)serialization logic with unit tests should be enough to confirm that the object has the correct structure. And ES does the validation on its end as well.
nit: comment on line 26 is not needed anymore.
Contributor
Author
|
Thanks for the review @yuliacech ! I am going to update the comment to capture the decision we made here so I will probably leave the link to the endpoint docs, but just state that we are intentionally not deeply validating the object structure. |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 25, 2020
* relax policy post route validation * update comment
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
that referenced
this pull request
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After implementing #83077 I noticed that on instances of Kibana that did not know about the shrink action we are unable to update a policy through UI because of server-side validation. The thinking behind #83077 was that we want to preserve any values users may have configured through the ES API (even if Kibana does not know about it).
It seems that the simplest way to do this for now is to relax our server side policy validation. We can rely on ES to validate the policy configuration instead. The UI has control over fields it know about, the rest we pass back unaltered to ES.
Additionally, by relaxing our server-side validation we have less of a maintenance burden in case ES adds ILM policy features we have/will not support.