[src/cli/dev] remove broken and unused --open flag#83966
Merged
spalger merged 3 commits intoelastic:masterfrom Nov 23, 2020
Merged
[src/cli/dev] remove broken and unused --open flag#83966spalger merged 3 commits intoelastic:masterfrom
spalger merged 3 commits intoelastic:masterfrom
Conversation
spalger
added
Team:Operations
spalger
force-pushed
the
dev-cli/remove-open-flag
branch
from
e3238ac to
20e0f40
Compare
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Nov 20, 2020
pgayvallet
approved these changes
Nov 23, 2020
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
This was referenced Nov 23, 2020
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Nov 23, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Nov 23, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
spalger
added a commit
that referenced
this pull request
Nov 23, 2020
…84139) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
spalger
added a commit
that referenced
this pull request
Nov 23, 2020
…4137) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #24843 we added support for an
--openflag, which it doesn't seem anyone uses as it's been broken for months and we haven't heard anything about it. This removes support for the flag which I'm open to adding back in the future but first we need to rework the dev cli in a major way, and I think that will be easier if we have fewer untested features.