-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[APM] Only fetch custom links for users with a valid license #83836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Only fetch custom links for users with a valid license #83836
Conversation
|
Pinging @elastic/apm-ui (Team:apm) |
x-pack/plugins/apm/public/components/shared/TransactionActionMenu/TransactionActionMenu.tsx
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/shared/TransactionActionMenu/TransactionActionMenu.tsx
Show resolved
Hide resolved
cauemarcondes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this bug was introduced by this issue? I ask it because we only notify the usage when the POST API is called, not when the GET API is called to return all custom links. |
The linked PR added the following check to the kibana/x-pack/plugins/apm/server/routes/settings/custom_link.ts Lines 51 to 53 in 38aedcc
|
|
@cauemarcondes All feedback addressed |
cauemarcondes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, the new design looks way better, thanks for improving it. 🎉
…#83836) * [APM] Only fetch custom links when user has valid license * Rename more files for consistency * i18n fixes * Fix tests * Addess feedback and minor cleanup * Fix test (and more cleanup) * Make cachable # Conflicts: # x-pack/plugins/apm/jest.config.js # x-pack/plugins/apm/public/components/app/Settings/CustomizeUI/CustomLink/Title.tsx # x-pack/plugins/apm/public/components/app/Settings/CustomizeUI/CustomLink/index.tsx # x-pack/plugins/apm/public/components/shared/TransactionActionMenu/TransactionActionMenu.tsx
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
|
Where can I find the kibana linux 64-bit distribution for git 7.10 branch. |
|
Tests ok. |
Originally fixed in #83836 **Problem** When running in basic mode and navigates to the transactions details page a toast is display with the warning: >To create custom links, you must be subscribed to an Elastic Gold license or above. With it, you'll have the ability to create custom links to improve your workflow when analyzing your services. This is caused by a request to `GET internal/apm/settings/custom_links`. This PR ensures that only when users have a valid license custom links will be attempted loaded <img width="1705" alt="image" src="https://github.com/elastic/kibana/assets/209966/60c59c87-9837-4fbb-8172-5a4add121db0">
Originally fixed in #83836 **Problem** When running in basic mode and navigates to the transactions details page a toast is display with the warning: >To create custom links, you must be subscribed to an Elastic Gold license or above. With it, you'll have the ability to create custom links to improve your workflow when analyzing your services. This is caused by a request to `GET internal/apm/settings/custom_links`. This PR ensures that only when users have a valid license custom links will be attempted loaded <img width="1705" alt="image" src="https://github.com/elastic/kibana/assets/209966/60c59c87-9837-4fbb-8172-5a4add121db0">

Fixes issue reported on Discuss where custom links result in an error for users on basic license.
Improvements:
TransactionActionMenucomponent by co-locating everything related to custom links in theCustomLinkMenuSectionBug introduced in 7.10 by #77630
How to downgrade to basic license: