do not export types from 3rd party modules as 'type'

[mshustov]

Problem is reported in
#82300 (comment)

Output in the current configuration:
packages/kbn-i18n/target/types/react/index.d.ts

import { InjectedIntl as _InjectedIntl, InjectedIntlProps as _InjectedIntlProps } from 'react-intl';
export declare type InjectedIntl = _InjectedIntl;
export declare type InjectedIntlProps = _InjectedIntlProps;
export { intlShape, FormattedDate, FormattedTime, FormattedRelative, FormattedNumber, FormattedPlural, FormattedMessage, FormattedHTMLMessage, IntlProvider as __IntlProvider, } from 'react-intl';
export { I18nProvider } from './provider';
export { injectI18n } from './inject';
//# sourceMappingURL=index.d.ts.map

packages/kbn-test/target/types/jest/utils/enzyme_helpers.d.ts

/// <reference types="cheerio" />
/// <reference types="jest" />
import { ReactWrapper } from 'enzyme';
import React, { ReactElement, ValidationMap } from 'react';
/**
 *  Creates the wrapper instance using shallow with provided intl object into context
 *
 *  @param node The React element or cheerio wrapper
 *  @param options properties to pass into shallow wrapper
 *  @return The wrapper instance around the rendered output with intl object in context
 */
export declare function shallowWithIntl<T>(node: ReactElement<T>, { context, childContextTypes, ...props }?: {
    context?: any;
    childContextTypes?: ValidationMap<any>;
}): import("enzyme").ShallowWrapper<T & {
    intl: ReactIntl.InjectedIntl;
}, Readonly<{}>, React.Component<{}, {}, any>>;
// ...

Note that InjectedIntl type is not imported from @kbn/i18n/react, but rather referenced by the value. I saw a similar problem reported in https://www.techatbloomberg.com/blog/10-insights-adopting-typescript-at-scale/
It doesn't explain why we don't see any problems on master, but on #82300 PR ReactIntl cannot be inferred. Anyway, the global namespace is not something we want to rely on, so there are 2 options:

• switch from type to interface
• export the namespace explicitly

for both options the InjectedIntl imported explicitly in the emitted d.ts file:
packages/kbn-test/target/types/jest/utils/enzyme_helpers.d.ts

/// <reference types="cheerio" />
/// <reference types="jest" />
/**
 * Components using the @kbn/i18n module require access to the intl context.
 * This is not available when mounting single components in Enzyme.
 * These helper functions aim to address that and wrap a valid,
 * intl context around them.
 */
import { InjectedIntl } from '@kbn/i18n/react';
import { ReactWrapper } from 'enzyme';
import React, { ReactElement, ValidationMap } from 'react';
/**
 *  Creates the wrapper instance using shallow with provided intl object into context
 *
 *  @param node The React element or cheerio wrapper
 *  @param options properties to pass into shallow wrapper
 *  @return The wrapper instance around the rendered output with intl object in context
 */
export declare function shallowWithIntl<T>(node: ReactElement<T>, { context, childContextTypes, ...props }?: {
    context?: any;
    childContextTypes?: ValidationMap<any>;
}): import("enzyme").ShallowWrapper<T & {
    intl: InjectedIntl;
}, Readonly<{}>, React.Component<{}, {}, any>>;

As a follow up, I'm going to reproduce the problem on a smaller codebase and reach out the TS team. We might want to adopt Prefer interfaces eslint rule. It seems to be an approach recommended by TS team https://twitter.com/drosenwasser/status/1319205169918144513

[elasticmachine]

Pinging @elastic/kibana-operations (Team:Operations)

[elasticmachine]

Pinging @elastic/kibana-core (Team:Core)

[spalger]

Wow, I can't rationalize how this is actually different from the previous code... This seems like a bug in TS and I'm glad you hear you plan to report it to the TS team... I'm shocked that you figured this out.

[Bamieh]

Very odd indeed.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 0ec0f75

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream