[index patterns] Field custom name => custom label #83717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattkime
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
mattkime
added
Feature:Data Views
kertal
approved these changes
Nov 19, 2020
Member
kertal
left a comment
kertal
left a comment
There was a problem hiding this comment.
Code LGTM, on more change it this should be fine, think that labeling it label is much better 👍
src/plugins/index_pattern_management/public/components/field_editor/field_editor.tsx
Outdated
Show resolved
Hide resolved
…ditor/field_editor.tsx Co-authored-by: Matthias Wilhelm <[email protected]>
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
mattkime
added a commit
to mattkime/kibana
that referenced
this pull request
Nov 19, 2020
* custom name => custom label
mattkime
added a commit
that referenced
this pull request
Nov 20, 2020
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Renaming the field
custom nametocustom label.Custom labelis a bit more specific as this is only used for display in the UI. In the future it will be possible to define new fields on the index pattern and the name of those fields will be defined by the user making 'custom name' insufficiently distinct.Checklist