Skip to content

Prevent visualization element from blocking mouse interaction in test:dev UI.#8364

Merged
cjcenizal merged 1 commit intoelastic:masterfrom
cjcenizal:improvement/test-dev-ui
Sep 20, 2016
Merged

Prevent visualization element from blocking mouse interaction in test:dev UI.#8364
cjcenizal merged 1 commit intoelastic:masterfrom
cjcenizal:improvement/test-dev-ui

Conversation

@cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Sep 20, 2016

When you run npm run test:dev, a Chrome instance opens up that displays the results of tests as they run. You can click on a test to restrict subsequent re-runs to just that test. If you try to click a test or test suite in the top half of the Chrome window, there's a visualization element that blocks your click. This PR adds pointer-events: none to that element to solve this problem.

@jbudz jbudz self-assigned this Sep 20, 2016
@jbudz
Copy link
Contributor

jbudz commented Sep 20, 2016

LGTM

@cjcenizal cjcenizal merged commit 2dbe4b9 into elastic:master Sep 20, 2016
@cjcenizal cjcenizal deleted the improvement/test-dev-ui branch September 20, 2016 17:54
elastic-jasper added a commit that referenced this pull request Sep 20, 2016
---------

**Commit 1:**
Prevent visualization element from blocking mouse interaction in test:dev UI.

* Original sha: 9907f93
* Authored by CJ Cenizal <cj@cenizal.com> on 2016-09-20T02:12:22Z
elastic-jasper added a commit that referenced this pull request Sep 20, 2016
---------

**Commit 1:**
Prevent visualization element from blocking mouse interaction in test:dev UI.

* Original sha: 9907f93
* Authored by CJ Cenizal <cj@cenizal.com> on 2016-09-20T02:12:22Z
cjcenizal added a commit that referenced this pull request Sep 20, 2016
[backport] PR #8364 to 5.x - Prevent visualization element from blocking mouse interaction in test:dev UI.
cjcenizal added a commit that referenced this pull request Sep 20, 2016
[backport] PR #8364 to 5.0 - Prevent visualization element from blocking mouse interaction in test:dev UI.
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
---------

**Commit 1:**
Prevent visualization element from blocking mouse interaction in test:dev UI.

* Original sha: c09f7b1a91c80abdcdd3d64e11328dc20ba5a453 [formerly 9907f93]
* Authored by CJ Cenizal <cj@cenizal.com> on 2016-09-20T02:12:22Z


Former-commit-id: 06794d2
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
[backport] PR elastic#8364 to 5.x - Prevent visualization element from blocking mouse interaction in test:dev UI.

Former-commit-id: 632c7fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments