-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Discover] New responsive layout using EUI components #83633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kertal
merged 241 commits into
elastic:master
from
kertal:kertal-2020-11-18-responsive-layout
Dec 3, 2020
Merged
Changes from 196 commits
Commits
Show all changes
241 commits
Select commit
Hold shift + click to select a range
e6671e5
initial discover DataGrid proof of concept
cd000cf
fixing scss import
581fe40
Merge remote-tracking branch 'upstream/master' into discover-data-grid
c13b349
bringing back old table with advanced setting
5f19bf2
fixing old tests
6543d26
removing hide fields action and fixing field add/sub bug
f4fd8c2
fixing old tests
472e240
adding tests
6105c05
added new test
5721112
Merge remote-tracking branch 'upstream/master' into discover-data-grid
4d4b63f
json field formatter work
179ee06
fixing old test
9cf8c75
futzing with tests
a81dc9a
i18n fix
977c637
only show _source when no other columns are shown
887bf3a
more test fixes
61422fd
Merge remote-tracking branch 'upstream/master' into discover-data-grid
d6c156c
Merge remote-tracking branch 'upstream/master' into discover-data-grid
44c4319
Merge remote-tracking branch 'upstream/master' into discover-data-grid
70c6a33
add docs for new legacyTable advanced setting
7ac7f9b
basic layout
snide b50c90b
design changes to dg
snide 9eb57e6
Merge remote-tracking branch 'upstream/master' into discover-data-grid
156a558
perf improvements
mbondyra 8761909
Merge branch 'discover-data-grid' of github.com:myasonik/kibana into …
snide f6b2cee
basic layout and scrolling now works
snide 78a7405
attempting to get tests to pass again
2bc70e9
fixed infinite scroll of legacy table
1702235
fixing sorting and schema detection and other bugs
b3b873d
Merge remote-tracking branch 'upstream/master' into discover-data-grid
c372a0d
updating to use new state stuff
464eb22
Merge remote-tracking branch 'upstream/master' into discover-data-grid
snide 6443dea
Merge master /fix conflicts
kertal 6809cfc
Merge commit 'dcfa4850098972b6b00fe869048e61602aea4683' into kertal-p…
kertal 5c97e03
Merge master /fix conflicts
kertal 0819ae5
Activate DataGrid in embeddable
kertal 3cfe3d3
Add missing setLegacyDiscoverTable
kertal 2378865
Remove discover_page.js
kertal 1afe791
Fix tests
kertal 7febeb6
Fix i18n
kertal 0b37c40
Add uiSettings
kertal c2d44e3
Fix pagination
kertal 6921cbf
Fix i18n
kertal b821f58
Improve performance
kertal bf18d72
Implement column selection
kertal 57adb3f
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal 3ca7c95
Adapt Histogram layout
kertal b8ff6b1
Merge master /fix conflicts
kertal 485ad26
Fix adding columns
kertal 3388519
Make position of timecolumn sortable
kertal f3b90e6
Modify naming of a indexpatterns timefield
kertal d54621d
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal fedddb9
Undo accidentally commited kbn-pm changes
kertal c285360
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal 1334dec
Undo accidentally commited kbn-pm changes II
kertal f440260
Merge master /fix conflicts
kertal 75db54e
Improve performance by removing inMemory property of EuiDataGrid
kertal 2a1cc5d
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal 82b164c
Fix the header/EuiDataGrid overlapping
kertal 36984e2
Migrate flyout and popover to separate files
kertal 637950d
Improve performance
kertal 3b18bc4
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal 0b9deb0
Code improvements
kertal 5c7b26c
Even more code improvements
kertal 3d84981
Debugging version for chandler
kertal 5c2cfc5
Refactor to use context for flyout
kertal 5c4b98d
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal b413092
Refactor to use context for flyout II
kertal 7a5db46
Datagrid vision
kertal 1281668
Merge master /fix conflicts
kertal 80ad99e
cleanup and split of components into files
kertal 43e5bce
Merge master
kertal b73f4e6
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal 9395e51
Migrate discover.html to discover.tsx
kertal 9048c18
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal be0dcb7
Fix filters
kertal 8a504bc
Improve CSS
kertal 81cba19
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal 9136db3
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal ddfedda
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal e0cb6a8
Add column header actions
kertal 9a5dc1c
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal c502415
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal d053550
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal acdc592
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal 096a81d
Fix tests
kertal 7682282
adding toggle of chart
andreadelrio 369dd1d
Merge master /fix conflicts
kertal 62b480f
Fix tests
kertal 9a26fcf
Fix i18n
kertal a1151df
Use EuiResizableContainer to make columns resizeable
kertal 2039f1c
fix conflict
andreadelrio d9c9997
merged from kertal's branch
andreadelrio e751fd4
clean sass file
andreadelrio 539b1ac
improve dscResultCount in smaller screens
andreadelrio 6c8bf2d
Merge pull request #6 from andreadelrio/hide-chart
kertal 16b0a8c
Merge master/fix conflicts
kertal ae4ee04
Merge branch 'kertal-pr-2020-04-25-discover-data-grid' of github.com:…
kertal 7a243bb
Fix type error
kertal 0c79e40
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal a26169f
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal 2cde541
Rename doc_table:legacyTable to doc_table:legacy for eslint
kertal 182bea2
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal 70fb429
Use records instead of hits as wording
kertal 381e3bf
Enable persistence of data grid columns width
kertal 8a780b9
improve expanded doc flyout design
andreadelrio 72bdf33
remove EuiLink
andreadelrio e226a84
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal f4bac9c
Fix legacy embeddable
kertal c09e420
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal 638d0e7
Enable columnsWidth in embeddable, remove filters from cell
kertal e24ab3e
Fix types
kertal d070949
Fix context href
kertal e4750d8
Merge pull request #7 from andreadelrio/expandedDocFlyout
kertal 59de5e8
Merge master/fix conflicts
kertal c52931d
Improve dashboard code, add no results rendering
kertal 4df03eb
temporarily remove EuiResizableContainer
andreadelrio 760b84a
need to move button to the right section
andreadelrio 39cb3b2
working on Fields mobile button
andreadelrio df9a482
improve Fields button in mobile
andreadelrio aaee7e2
Merge master / fix conflicts
kertal 997c00f
didn't really need an extra component
andreadelrio 9e74d0c
available fields accordion
andreadelrio 38acb01
lots of cleanup
andreadelrio e582aa3
Merge master / fix conflicts
kertal 28f8897
Fix functional test
kertal a04bc8d
Refactor getDefaultState
kertal 0f8bc2f
i18n for fields
andreadelrio b2ad20d
Merge master / fix conflicts
kertal 8793fb4
fix No Results screen on mobile
andreadelrio ee40566
improve Expanded Document flyout in mobile
andreadelrio 709afd9
give tokens color
andreadelrio 8830406
add NotificationBadge to accordions
andreadelrio e629524
add EuiShowFor and EuiHideFor
andreadelrio aae3b7e
make NotificationBadges in sidebar consider filters
andreadelrio e4f3e89
update Filter button on sidebar
andreadelrio 2e30b1e
removed some boostrap and did some cleanup in legacy
andreadelrio 567b6f2
show the flyout in legacy
andreadelrio 0aa72ed
Merge master / fix conflicts
kertal 03af0ce
Shared state refactoring
kertal 789e469
Fix flyover not showing icons permanetly
kertal b6d3a93
update loading screens
andreadelrio 8127b20
fix empty state
andreadelrio 4ad36d9
remove fixed height
andreadelrio 88cb1d2
Fix infinite scrolling
kertal 429e4a4
Adapt infinite scrolling, allow user to hide chart in legacy
kertal fd5fe4f
couple of tiny styling fixes
andreadelrio 9a29cfb
revert
andreadelrio fbd920a
Merge pull request #8 from andreadelrio/responsive-discover
andreadelrio 0ca31a4
Merge and fix conflicts
kertal d0d81cf
Merge and fix conflicts
kertal 121d0d0
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal e8a9b08
Fix jest test + type errors + unused variables
kertal e2232c8
Merge and fix conflicts
kertal e56455c
Fix a11y test
kertal e7f7edf
Fix skipToBottom button
kertal 5b5385a
Adapt mocks
kertal 7b74b09
Add JSON schema rendering
kertal d6f89ac
Fix _source schema
kertal 4ca957d
Fix a11y tests
kertal 9383958
Improve loading spinner for legacy
kertal 7fa93ee
Fix functional tests
kertal 9663022
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal 2b10e04
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal bce5d48
Fix dashboard rendering, refactor col width persistence
kertal b89e980
fix datagrid in fullscreen
andreadelrio cca4d3e
Improve document selection code
kertal 5099bed
better fix
andreadelrio f94a073
Merge upstream, fix conflicts
kertal 52afe76
Fix conflicts
kertal 379ba45
Merge pull request #9 from andreadelrio/dg-fullscreen
kertal 679bee9
Fix get_inner_angular.ts
kertal 2b9fb24
Merge branch 'kertal-pr-2020-04-25-discover-data-grid' of github.com:…
kertal e1e52f0
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal f9fe460
Simplify code and cleanup CSS
kertal 61ef7cc
Merge and fix conflicts
kertal 06239d7
Fix types
kertal 1e64917
Fix types
kertal c66dca5
Cleanup
kertal fa36978
simple cleanup to Selected Records flyout
andreadelrio 5c9c203
Merge pull request #11 from andreadelrio/sr-basic
kertal 7864bed
Merge and fix conflicts
kertal 5bdeaeb
Merge branch 'kertal-pr-2020-04-25-discover-data-grid' of github.com:…
kertal 40c8419
Fix column actions displayed in expand column
kertal 495500a
Cleanup code
kertal 3b85fbb
Merge remote-tracking branch 'upstream/master' into kertal-pr-2020-04…
kertal daf9939
Remove selection code (to restore in a different PR)
kertal ab68cfd
Merge and fix conflicts
kertal f4c6d77
Extract layout changes
kertal 979e2e9
Improve code, fix TODO
kertal 743e09f
Improve tests
kertal 5e206a9
Improve scroll to top functionality
kertal 120f5bc
Clean up code
kertal 6cce664
Improve code
kertal a72ff1f
Merge remote-tracking branch 'upstream/master' into kertal-2020-11-18…
kertal 1a91fca
Address review comments
kertal ab8dae6
Add aria label to flyout back button
kertal acc7c0b
Merge branch 'master' into kertal-2020-11-18-responsive-layout
kibanamachine d5021fe
Merge remote-tracking branch 'upstream/master' into kertal-2020-11-18…
kertal a4dd457
Merge remote-tracking branch 'upstream/master' into kertal-2020-11-18…
kertal 13cadc2
Fix doc viewer button width
kertal 189f308
Cleanup `dscFieldSearch__toggleButton`
kertal 6e568ba
Cleanup css classes
kertal 68891dd
Merge branch 'kertal-2020-11-18-responsive-layout' of github.com:kert…
kertal b6b365e
Memoize components for better performance
kertal 4299b37
change location of skip button
andreadelrio 422cc3a
Merge branch 'kertal-2020-11-18-responsive-layout' of https://github.…
andreadelrio 28d2a4f
change styling of skip button
andreadelrio 8a07ee8
improve prompt screen when search on load is disabled
andreadelrio 2725d5b
adjust space between Selected and Available fields
andreadelrio b75e1b9
Improve scroll to top functionality
kertal aa74f86
Basic layout now using EuiPage components
e99576b
Merge branch 'kertal-2020-11-18-responsive-layout' of github.com:kert…
bd98104
Cleanup of class names and styles
ede3d6e
Cleaning up old style and fixing up mobile flyout
fd76825
Merge branch 'kertal-2020-11-18-responsive-layout' of github.com:kert…
kertal 0c031e8
Merge remote-tracking branch 'upstream/master' into kertal-2020-11-18…
kertal 1aa09c3
Cleanups
kertal 06896a7
Merge and fix conflicts
kertal 0ef34ed
Merge branch 'kertal-2020-11-18-responsive-layout' of github.com:kert…
fb8ad1d
Fixing position of skip button
d1eaf73
Using centered content for uninitialized
6ad3db6
Fixed scroll to top
d234a7d
A few more fixes
a44ef6f
Fix infinite_scroll.ts
kertal 5106a76
Merge pull request #12 from cchaos/discover/responsive-layout
kertal 2207ea0
Fix functional tests
kertal ab971e0
Fix redundant import
kertal bdf05da
Fix scroll to top for mobile
kertal 72d20a5
Merge remote-tracking branch 'upstream/master' into kertal-2020-11-18…
kertal 762772c
Refactorings, address review comments
kertal e4421a5
Improve scroll to bottom code
kertal 99847d8
Merge branch 'master' into kertal-2020-11-18-responsive-layout
kibanamachine 2e8dd8b
Fix functional test
kertal 9ab6fd6
Merge branch 'kertal-2020-11-18-responsive-layout' of github.com:kert…
kertal 27779c1
Address wording review comments
kertal 9fa4f3f
Merge remote-tracking branch 'upstream/master' into kertal-2020-11-18…
kertal ee164b0
Merge branch 'master' into kertal-2020-11-18-responsive-layout
kibanamachine 0ebf5a7
Add i18 for showing, hiding the chart
kertal 6a8acc8
Merge branch 'kertal-2020-11-18-responsive-layout' of github.com:kert…
kertal c687048
Migrate types to use ElasticSearchHit
kertal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
155 changes: 0 additions & 155 deletions
155
src/plugins/discover/public/application/angular/directives/fixed_scroll.js
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.