[Metrics UI] Converting legend key to optional #83495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
added
release_note:fix
Feature:Metrics UI
Contributor
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Nov 18, 2020
* [Metrics UI] Converting legend key to optional * Adding check and default to legend component
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Nov 18, 2020
* [Metrics UI] Converting legend key to optional * Adding check and default to legend component
simianhacker
added a commit
that referenced
this pull request
Nov 18, 2020
simianhacker
added a commit
that referenced
this pull request
Nov 18, 2020
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Nov 18, 2020
…o-node-details * 'master' of github.com:elastic/kibana: SO Tagging: fix flaky test and re-enable it (elastic#82930) [Metrics UI] Converting legend key to optional (elastic#83495)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes https://github.com/elastic/sdh-kibana/issues/970 by making the legend key optional on the waffle map options state