[Alerting UI] Fix console error when setting connector params #83333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymao1
commented
Nov 12, 2020
|
|
||
| const [isSaving, setIsSaving] = useState<boolean>(false); | ||
|
|
||
| const closeFlyout = useCallback(() => { |
Contributor
Author
There was a problem hiding this comment.
Removed the following lines because I was seeing another console error when saving a connector. With this PR #82126, the connector flyouts are destroyed when closed instead of hidden, so setting these states on closing was causing a Warning: Can't perform a React state update on an unmounted component. browser error.
ymao1
changed the title
ymao1
changed the title
ymao1
added
Feature:Alerting
release_note:skip
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
YulNaumenko
approved these changes
Nov 16, 2020
Contributor
YulNaumenko
left a comment
YulNaumenko
left a comment
There was a problem hiding this comment.
LGTM! Tested locally and it works like a magic 👍
mikecote
approved these changes
Nov 17, 2020
Contributor
mikecote
left a comment
mikecote
left a comment
There was a problem hiding this comment.
Changes LGTM, tested locally 👍
ymao1
added a commit
to ymao1/kibana
that referenced
this pull request
Nov 17, 2020
…c#83333) * Fixing console errors * Setting defaults for undefined inputs in text area/field with message variables * Cleanup * Cleanup * Fixing pagerduty timestamp validation * Fixing test * Pagerduty params * Reverting unnecessary changes
ymao1
added a commit
that referenced
this pull request
Nov 17, 2020
#83537) * Fixing console errors * Setting defaults for undefined inputs in text area/field with message variables * Cleanup * Cleanup * Fixing pagerduty timestamp validation * Fixing test * Pagerduty params * Reverting unnecessary changes
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 17, 2020
* master: (51 commits) [ML] Persisted URL state for the Data frame analytics jobs and models pages (elastic#83439) adds xpack.security.authc.selector.enabled setting (elastic#83551) skip flaky suite (elastic#77279) [ML] Improve support for script and aggregation fields in anomaly detection jobs (elastic#81923) [Workplace Search] Migrate SourcesLogic from ent-search (elastic#83544) [ML] Add UI test for feature importance features (elastic#82677) [Maps] Improve icons for all layer types (elastic#83503) Replace experimental badge with Beta (elastic#83468) [Fleet][EPM] Unified install and archive (elastic#83384) Move src/legacy/server/keystore to src/cli (elastic#83483) Used SO for saving the API key IDs that should be deleted (elastic#82211) [Uptime] Mock implementation to account for math flakiness test (elastic#83535) [Workplace Search] Enable check for org context based on URL (elastic#83487) [App Search] Added all Document related routes and logic (elastic#83324) [Alerting UI] Fix console error when setting connector params (elastic#83333) [Discover] Allow custom name for fields via index pattern field management (elastic#70039) [Uptime] Fix monitor list down histogram (elastic#83411) remove headers timeout hack, rely on nodejs timeouts (elastic#83419) [ML] Update console autocomplete for ML data frame evaluate API (elastic#83151) [Lens] Color in dimension trigger (elastic#76871) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #83078
Summary
This is fixed by setting a default to an empty string in the
TextAreaWithMessageVariablesandTextFieldWithMessageVariablescomponents when the input is undefined. If the initial input is undefined, the form control is uncontrolled, then setting a value changes the input to controlled, causing the console error seen in the issue. The issue specifically called out the PagerDuty connector but I also saw this behavior in other connector param forms.To verify: