[Alerting UI] Replaced AppContextProvider introduced by the plugin with KibanaContextProvider #83248

YulNaumenko · 2020-11-12T05:42:36Z

Current PR include the next changes:

Replaced AppContextProvider with KibanaContextProvider.
Released number of props which paths through the alerting components by replacing this with useKibana().services
Removed ActionsConnectorsContextProvider
Replaces mocks for context dependancies with kibana_react.mock. Unit tests code reduced and simplified.
Extended TriggersAndActionsUIPublicPluginStart with exposed connector flyouts: AddConnectorFlyout and EditConnectorFlyout. This allows to reduce the number of pathed dependancies and remove require of the code directly from our plugins.

Resolve #65146

…xtProvider

… result

elasticmachine · 2020-11-18T20:17:10Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

elasticmachine · 2020-11-18T20:35:49Z

Pinging @elastic/uptime (Team:uptime)

shahzad31 · 2020-11-20T09:15:45Z

@YulNaumenko now it seems to work fine, but when i click create connector is uptime settings, it seems to open flyout twice, there is some flaky behaviour , i will try to post a gif later on.

gmmorris

I've checked the lazy loading chuck size and the UX throughout Alerts Management and flyouts in solutions and looks like everything is still working as expected. 👍

gmmorris · 2020-11-20T11:04:54Z

@YulNaumenko now it seems to work fine, but when i click create connector is uptime settings, it seems to open flyout twice, there is some flaky behaviour , i will try to post a gif later on.

~~I tried to reproduce and couldn't - are you sure you've pulled the latest changes?~~

NVM, I was looking at the Alerts flyout, not the Connectors.
It does seem to double render... possibly there's something causing unnecessary renders caused by a missing useMemo or useCallback

cnasikas

Hi! Thank you so much for doing this. I tested locally and it seems there are some flaky behavior and an error.

The edit flyout seems to open and close multiple times when you update credentials:

When you enter the configuration page of cases it seems that one of the flyouts opens and closes instantly:

When you press the test tab you get the following error:

phillipb

Looks good for logs and metrics.

shahzad31

Uptime changes LGTM !!

cnasikas

Security Solution changes LGTM! All issues have been resolved! Thank you!

...gers_actions_ui/public/application/components/builtin_action_types/email/email_connector.tsx

...ctions_ui/public/application/components/builtin_action_types/es_index/es_index_connector.tsx

...ons_ui/public/application/components/builtin_action_types/pagerduty/pagerduty_connectors.tsx

...s_ui/public/application/components/builtin_action_types/servicenow/servicenow_connectors.tsx

...ers_actions_ui/public/application/components/builtin_action_types/slack/slack_connectors.tsx

...ers_actions_ui/public/application/components/builtin_action_types/teams/teams_connectors.tsx

kibanamachine · 2020-11-24T07:44:18Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: dfd83b4

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`triggersActionsUi`	282	283	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	7.9MB	7.9MB	-587.0B
`triggersActionsUi`	1.5MB	1.5MB	+21.1KB
`uptime`	984.1KB	983.7KB	-499.0B
total			+20.0KB

Distributable file count

id	before	after	diff
`default`	43058	43052	-6

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`triggersActionsUi`	154.7KB	161.0KB	+6.2KB

Unknown metric groups

async chunk count

id	before	after	diff
`triggersActionsUi`	33	31	-2

History

💔 Build #89858 failed 936c8d8
💚 Build #89721 succeeded 50c2c54
💔 Build #89751 failed 81fac32
💚 Build #89501 succeeded 2f267bb
💔 Build #89500 failed 9f1b65c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2020-11-26T08:14:39Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kibanamachine · 2020-11-27T08:24:38Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kibanamachine · 2020-11-30T08:34:38Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

YulNaumenko added 2 commits November 11, 2020 21:38

Replaced AppContextProvider introduced by the plugin with KibanaConte…

e8958fa

…xtProvider

Removed unused files

1f8a681

YulNaumenko added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.11.0 labels Nov 12, 2020

YulNaumenko self-assigned this Nov 12, 2020

YulNaumenko added 5 commits November 13, 2020 15:09

Merge remote-tracking branch upstream/master

d106cd5

Fixed jest test

bf223f0

Removed ActionsConnectorContext

69d847b

Merge remote-tracking branch upstream/master

76280df

exposed addConnectorFlyout and editConnectorFlyouts as a plugin start…

ee73051

… result

YulNaumenko force-pushed the alerting-ui-introduce-kibana-context branch from 8dab255 to ee73051 Compare November 18, 2020 17:29

YulNaumenko added 5 commits November 18, 2020 10:19

removed rest of unused connectors context

0db31a0

fixed capabilities

d4ace4d

fixed jest tests

7ddf1cf

fixed jest tests

fbfce05

fixed jest tests

dc0e5bc

YulNaumenko marked this pull request as ready for review November 18, 2020 20:17

YulNaumenko requested review from a team as code owners November 18, 2020 20:17

fixed uptime

70057e7

botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Nov 18, 2020

YulNaumenko added 2 commits November 18, 2020 13:27

fixed typecheck errors

1404507

fixed typechecks

d7ac941

YulNaumenko requested a review from gmmorris November 19, 2020 19:05

YulNaumenko added 2 commits November 19, 2020 12:34

fixed type check

912aa83

removed orig files

f0066b6

gmmorris approved these changes Nov 20, 2020

View reviewed changes

cnasikas reviewed Nov 20, 2020

View reviewed changes

fixed cases UI issues

1f31f65

YulNaumenko requested a review from cnasikas November 20, 2020 23:10

phillipb approved these changes Nov 21, 2020

View reviewed changes

YulNaumenko added 3 commits November 22, 2020 21:09

Merge remote-tracking branch upstream/master

9f1b65c

fixed due to comments

2f267bb

fixed due to comments

50c2c54

shahzad31 approved these changes Nov 23, 2020

View reviewed changes

Merge remote-tracking branch upstream/master

81fac32

cnasikas approved these changes Nov 23, 2020

View reviewed changes

YulNaumenko added 2 commits November 23, 2020 20:00

fixed kibana crash

936c8d8

fixed es-lint

dfd83b4

YulNaumenko merged commit b11f783 into elastic:master Nov 24, 2020

YulNaumenko mentioned this pull request Nov 24, 2020

[7.x] [Alerting UI] Replaced AppContextProvider introduced by the plugin with KibanaContextProvider (#83248) #84247

Closed

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 26, 2020

mikecote mentioned this pull request Nov 26, 2020

[Alerting] embedding the flyout requires host solutions to manually require alerting deps #61094

Closed

igoristic mentioned this pull request Nov 30, 2020

[Monitoring][Alerting] Added core features to Kibana services #84486

Merged

YulNaumenko mentioned this pull request Nov 30, 2020

[7.x] [Alerting UI] Replaced AppContextProvider introduced by the plugin with KibanaContextProvider (#83248) #84596

Merged

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 1, 2020

igoristic mentioned this pull request Dec 4, 2020

[Monitoring][Alerting] Added core features to Kibana services UPDATED #85074

Merged

[Alerting UI] Replaced AppContextProvider introduced by the plugin with KibanaContextProvider #83248

[Alerting UI] Replaced AppContextProvider introduced by the plugin with KibanaContextProvider #83248

Uh oh!

Conversation

YulNaumenko commented Nov 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Nov 18, 2020

Uh oh!

elasticmachine commented Nov 18, 2020

Uh oh!

shahzad31 commented Nov 20, 2020

Uh oh!

gmmorris left a comment

Choose a reason for hiding this comment

Uh oh!

gmmorris commented Nov 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cnasikas left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

phillipb left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shahzad31 left a comment

Choose a reason for hiding this comment

Uh oh!

cnasikas left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kibanamachine commented Nov 24, 2020

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Distributable file count

Page load bundle

async chunk count

History

Uh oh!

kibanamachine commented Nov 26, 2020

Uh oh!

kibanamachine commented Nov 27, 2020

Uh oh!

kibanamachine commented Nov 30, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

YulNaumenko commented Nov 12, 2020 •

edited

Loading

gmmorris commented Nov 20, 2020 •

edited

Loading

cnasikas left a comment •

edited

Loading

phillipb left a comment •

edited

Loading

cnasikas left a comment •

edited

Loading