Skip to content

[Security Solution][Detections] - follow up cleanup on auto refresh rules #83023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2020
Merged

[Security Solution][Detections] - follow up cleanup on auto refresh rules #83023

merged 1 commit into from
Nov 10, 2020

Conversation

@yctercero
Copy link
Contributor

@yctercero yctercero commented Nov 9, 2020 •
edited
Loading

Summary

This is a follow up cleanup PR to #82062 . There were a few comments I hadn't gotten to and wanted to follow up on.

Checklist

@yctercero yctercero added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Detection Rules Security Solution rules and Detection Engine Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.11 labels Nov 9, 2020
@yctercero yctercero self-assigned this Nov 9, 2020
@yctercero yctercero mentioned this pull request Nov 9, 2020
Merged
6 tasks
@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 10, 2020

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.8MB 7.8MB +536.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yctercero yctercero marked this pull request as ready for review November 10, 2020 02:22
@yctercero yctercero requested review from a team as code owners November 10, 2020 02:22
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 10, 2020

Pinging @elastic/siem (Team:SIEM)

madirey
madirey approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@madirey madirey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough, looks like all the feedback was addressed. 👍

@yctercero yctercero merged commit 00ca555 into elastic:master Nov 10, 2020
@yctercero yctercero deleted the follow_up_rules_refresh branch November 10, 2020 15:50
phillipb added a commit to phillipb/kibana that referenced this pull request Nov 10, 2020
@phillipb
Merge branch 'bootstrap-node-details-overlay' of github.com:phillipb/…
4134c8c 
…kibana into bootstrap-node-details-overlay

* 'bootstrap-node-details-overlay' of github.com:phillipb/kibana: (49 commits)
  [Security Solution] Fix DNS Network table query (elastic#82778)
  [Workplace Search] Consolidate groups routes (elastic#83015)
  Adds cloud links to user menu (elastic#82803)
  [Security Solution][Detections] - follow up cleanup on auto refresh rules (elastic#83023)
  [App Search] Added the log retention panel to the Settings page (elastic#82982)
  [Maps] show icon when layer is filtered by time and allow layers to ignore global time range (elastic#83006)
  [DOCS] Consolidates drilldown pages (elastic#82081)
  [Maps] add on-prem EMS config (elastic#82525)
  migrate i18n mixin to KP (elastic#81799)
  [bundle optimization] fix imports of react-use lib (elastic#82847)
  [Discover] Add metric on adding filter (elastic#82961)
  [Lens] Performance refactoring for indexpattern fast lookup and Operation support matrix computation (elastic#82829)
  skip flaky suite (elastic#82804)
  Fix SO query for searching across spaces (elastic#83025)
  renaming built-in alerts to Stack Alerts (elastic#82873)
  [TSVB] Disable using top_hits in pipeline aggregations (elastic#82278)
  [Visualizations] Remove kui usage (elastic#82810)
  [Visualizations] Make the icon buttons labels more descriptive (elastic#82585)
  [Lens] Do not reset formatting when switching between custom ranges and auto histogram (elastic#82694)
  Fix ilm navigation (elastic#81664)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 10, 2020
@gmmorris
Merge branch 'alerts/stack-alerts-public' of github.com:gmmorris/kiba…
0104cb6 
…na into alerts/stack-alerts-public

* 'alerts/stack-alerts-public' of github.com:gmmorris/kibana:
  [Security Solution] Fix DNS Network table query (elastic#82778)
  [Workplace Search] Consolidate groups routes (elastic#83015)
  Adds cloud links to user menu (elastic#82803)
  [Security Solution][Detections] - follow up cleanup on auto refresh rules (elastic#83023)
  [App Search] Added the log retention panel to the Settings page (elastic#82982)
  [Maps] show icon when layer is filtered by time and allow layers to ignore global time range (elastic#83006)
  [DOCS] Consolidates drilldown pages (elastic#82081)
  [Maps] add on-prem EMS config (elastic#82525)
  migrate i18n mixin to KP (elastic#81799)
  [bundle optimization] fix imports of react-use lib (elastic#82847)
  [Discover] Add metric on adding filter (elastic#82961)
  [Lens] Performance refactoring for indexpattern fast lookup and Operation support matrix computation (elastic#82829)
  skip flaky suite (elastic#82804)
  Fix SO query for searching across spaces (elastic#83025)
  renaming built-in alerts to Stack Alerts (elastic#82873)
  [TSVB] Disable using top_hits in pipeline aggregations (elastic#82278)
  [Visualizations] Remove kui usage (elastic#82810)
  [Visualizations] Make the icon buttons labels more descriptive (elastic#82585)
  [Lens] Do not reset formatting when switching between custom ranges and auto histogram (elastic#82694)
:
@yctercero yctercero mentioned this pull request Nov 10, 2020
Merged
yctercero added a commit to yctercero/kibana that referenced this pull request Nov 10, 2020
@yctercero
[Security Solution][Detections] - follow up cleanup on auto refresh r…
c13bbcd 
…ules (elastic#83023)

### Summary

This is a follow up cleanup PR to elastic#82062 . There were a few comments I hadn't gotten to and wanted to follow up on.
yctercero added a commit that referenced this pull request Nov 11, 2020
@yctercero
[Security Solution][Detections] - follow up cleanup on auto refresh r…
60c5cd9 
…ules (#83023) (#83089)

### Summary

This is a follow up cleanup PR to #82062 . There were a few comments I hadn't gotten to and wanted to follow up on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@madirey madirey madirey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yctercero yctercero

Labels

Feature:Detection Rules Security Solution rules and Detection Engine release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yctercero @kibanamachine @elasticmachine @madirey