Skip to content

[Workplace Search] Consolidate groups routes #83015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2020
Merged

[Workplace Search] Consolidate groups routes #83015

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d21f8c
[Workplace Search] Consolidate groups routes
scottybollinger Nov 9, 2020
37d10b3
Remove redundant test
scottybollinger Nov 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions x-pack/plugins/enterprise_search/server/routes/workplace_search/groups.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
registerShareGroupRoute,
registerAssignGroupRoute,
registerBoostsGroupRoute,
registerGroupsRoutes,
} from './groups';

describe('groups routes', () => {
Expand Down Expand Up @@ -392,4 +393,11 @@ describe('groups routes', () => {
});
});
});

describe('registerGroupsRoutes', () => {
it('runs without errors', () => {
const mockRouter = new MockRouter({} as any);
registerGroupsRoutes({ ...mockDependencies, router: mockRouter.router });
});
});
});
10 changes: 10 additions & 0 deletions x-pack/plugins/enterprise_search/server/routes/workplace_search/groups.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,3 +223,13 @@ export function registerBoostsGroupRoute({
}
);
}

export const registerGroupsRoutes = (dependencies: IRouteDependencies) => {
registerGroupsRoute(dependencies);
registerSearchGroupsRoute(dependencies);
registerGroupRoute(dependencies);
registerGroupUsersRoute(dependencies);
registerShareGroupRoute(dependencies);
registerAssignGroupRoute(dependencies);
registerBoostsGroupRoute(dependencies);
};
18 changes: 2 additions & 16 deletions x-pack/plugins/enterprise_search/server/routes/workplace_search/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,23 +7,9 @@
import { IRouteDependencies } from '../../plugin';

import { registerOverviewRoute } from './overview';
import {
registerGroupsRoute,
registerSearchGroupsRoute,
registerGroupRoute,
registerGroupUsersRoute,
registerShareGroupRoute,
registerAssignGroupRoute,
registerBoostsGroupRoute,
} from './groups';
import { registerGroupsRoutes } from './groups';

export const registerWorkplaceSearchRoutes = (dependencies: IRouteDependencies) => {
registerOverviewRoute(dependencies);
registerGroupsRoute(dependencies);
registerSearchGroupsRoute(dependencies);
registerGroupRoute(dependencies);
registerGroupUsersRoute(dependencies);
registerShareGroupRoute(dependencies);
registerAssignGroupRoute(dependencies);
registerBoostsGroupRoute(dependencies);
registerGroupsRoutes(dependencies);
};