[7.x] [Lens] Extend Datasource props validation with VisualizationGroups (#82607) #82958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lastic#82607) * ✨ First pass with visualization validation + error messages * 🔥 Remove indexpattern error handling for now * 🏷️ Fix type issues * ✅ Add getErrorMessage test for data table * ✅ Add tests for pie and metric error messages * 🌐 Fix i18n checks issues * 🐛 Fix last issue * ✅ Add more tests for the XY visualization validation code * 👌 Included all feedback from first review * ✏️ Off by one message * 🌐 Fix i18n duplicate id * 🌐 Fix last i18n issue * 🐛 Fixed a hook reflow issue * ♻️+✅ Reworked validation flow + tests * 🏷️ Fix type issue * 🐛 Improved XY corner cases validation logic * 🐛 Fix empty datatable scenario * ✨ + ✅ Improved error messages for invalid datasources + tests * 🌐 Add missing i18n translation * 🏷️ Fix type issues * 🌐 Fix i18n issues * ✨ Filter out suggestions which fail to build * 🚚 Migrate datatable validation logic to the building phase, handling it as building state * 🏷️ Fix type issue * ✏️ Add comment for future enhancements * ✏️ Updated comment * :world_with_meridians: Refactor axis labels * 🌐 Reworked few validation messages * 🐛 Fix break down validation + percentage charts * ✅ Align tests with new validation logic * ♻️ Fix suggestion panel validation to match main panel * 🌐 Fix i18n issues * 🔧 Fix some refs for validation checks in suggestions * 🐛 Fix missing key prop in multiple errors scenario * 🐛 Fix swtich issue from XY to partition * 🌐 Fix i18n messages and aligned tests * 🐛 Fix suggestions switching bug * :refactor: Add more validation + refactored validation logic in a single place * ✏️ Add note about lint hooks disable rule * 🚨 Fix linting issue * 🏗️ Add infra API for datasource advanced validation * ✅ Align tests with new API * ✅ Fix type issues in tests * 👌 Early exists added * ✨ Add layers groups to the API * ✅ Fix some broken test after the validation change * 👌 Move to disctionary shape Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: