Skip to content

Conversation

@thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Nov 5, 2020

Summary

[email protected][email protected]

  • Expanded EuiPanel API means more CSS classes and therefore snapshot updates
  • New screen reader text in EuiLink for external URLs means that "get element text" methods in test suites capture more text.
    • This additional text is not relevant in most tests, so we've removed it in strict text-matching tests
    • removeExternalLinkText is the current approach
    • Open to other suggestions, especially from security_solutions owners, who have the most tests affected

30.2.0

  • Added labelWidth and descriptionDisplay props to EuiSuggestItem (#4180)
  • Added screen reader notification if EuiLink opens in a new window (#4172)
  • Set external prop to true if EuiLink opens in a new window (#4172)
  • Added float and margin props to EuiImage (#4209)
  • Added color and borderRadius props to EuiPanel (#4194)
  • Updated the use case for the EuiPanel prop hasShadow (#4194)
  • Deprecated the onClick, betaBadgeLabel, betaBadgeTooltipContent, and betaBadgeTitle props of EuiPanel (#4194)

Bug fixes

  • Fixed issue with labelDisplay not being passed to EuiSuggestItem (#4180)
  • Fixed copy in EuiDataGrid's header menu's sort actions (#4199)

@thompsongl thompsongl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Nov 5, 2020
@thompsongl thompsongl marked this pull request as ready for review November 6, 2020 17:22
@thompsongl thompsongl requested review from a team as code owners November 6, 2020 17:22
@thompsongl thompsongl requested a review from a team November 6, 2020 17:22
@thompsongl thompsongl requested a review from a team as a code owner November 6, 2020 17:22
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to ES UI snapshots LGTM. Thanks for keeping us up-to-date, Greg!

@botelastic botelastic bot added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Nov 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security/Spaces changes LGTM - tested locally

Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alerting team related code LGTM

Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks good from Stack Monitoring side

Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes LGTM!

@thompsongl thompsongl added the EUI label Nov 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime snapshots changes LGTM !!

@ghost
Copy link

ghost commented Nov 16, 2020

💚 Build Succeeded

Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation changes lgtm

Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SIEM/Endpoint LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 420.7KB 420.9KB +274.0B
ml 5.2MB 5.2MB +778.0B
securitySolution 7.9MB 7.9MB +510.0B
total +1.5KB

Distributable file count

id before after diff
default 42849 42848 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
searchprofiler 48.3KB 48.4KB +178.0B
securitySolution 165.0KB 165.2KB +198.0B
visTypeTimeseries 134.5KB 135.0KB +452.0B
total +828.0B
Unknown metric groups

@kbn/ui-shared-deps asset size

id before after diff
css 650.1KB 663.5KB +13.5KB
[email protected] 2.4MB 2.4MB +3.2KB
kbn-ui-shared-deps.js 4.8MB 4.8MB +7.0B
total +16.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thompsongl thompsongl merged commit 8a7af5b into elastic:master Nov 17, 2020
thompsongl added a commit to thompsongl/kibana that referenced this pull request Nov 17, 2020
* eui to v30.2.0

* src snapshot updates

* x-pack euipanel snapshot updates

* x-pack external link updates

* security_solution_cypress external link text

* clean up
thompsongl added a commit that referenced this pull request Nov 18, 2020
* Upgrade EUI to v30.2.0 (#82730)

* eui to v30.2.0

* src snapshot updates

* x-pack euipanel snapshot updates

* x-pack external link updates

* security_solution_cypress external link text

* clean up

* fix bad merge resolution
phillipb added a commit to phillipb/kibana that referenced this pull request Nov 18, 2020
…o-node-details

* 'master' of github.com:elastic/kibana: (65 commits)
  update chromedriver dependency to 87 (elastic#83624)
  [TSVB] use new Search API for rollup search (elastic#83275)
  [TSVB] Y-axis has number formatting not considering all series formatters in the group (elastic#83438)
  [Logs UI] Update <LogStream /> internal state when its props change (elastic#83302)
  Add tag bulk action context menu (elastic#82816)
  [code coverage] adding plugin to flush coverage data (elastic#83447)
  [UsageCollection] Expose `KibanaRequest` to explicitly opted-in collectors (elastic#83413)
  Added eventBus to trigger and listen plotHandler event (elastic#83435)
  [Runtime fields] Editor phase 1 (elastic#81472)
  [Maps] Fix threshold alert issue resolving nested fields (elastic#83577)
  chore(NA): remove usage of unverified es snapshots (elastic#83589)
  [DOCS] Adds Elastic Contributor Program link (elastic#83561)
  Upgrade EUI to v30.2.0 (elastic#82730)
  Don't show loading screen during auto-reload (elastic#83376)
  Functional tests - fix esArchive mappings with runtime fields (elastic#83530)
  [deb/rpm] Create keystore after installation (elastic#76465)
  [rpm] Create default environment file at "/etc/sysconfig/kibana" (elastic#82144)
  [docker] removes workaround for missing crypto-policies-scripts subpackage (elastic#83455)
  [ML] Persisted URL state for the Data frame analytics jobs and models pages (elastic#83439)
  adds xpack.security.authc.selector.enabled setting (elastic#83551)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

EUI release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.11.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.