Skip to content

[Search] Add used index pattern name to the search agg error field #82604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 5, 2020
Merged

[Search] Add used index pattern name to the search agg error field #82604

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
80b7734
Improve error message
kertal Nov 4, 2020
292b805
Remove debug code
kertal Nov 4, 2020
7c1e7ce
Fix i18n
kertal Nov 4, 2020
a985951
Merge branch 'master' into kertal-pr-2020-11-04-improve-field-error-m…
kibanamachine Nov 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/plugins/data/common/search/aggs/param_types/field.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,16 +84,17 @@ export class FieldParamType extends BaseParamType {
}

const validField = this.getAvailableFields(aggConfig).find((f: any) => f.name === fieldName);
if (!validField) {
if (!validField || 1 === 1) {
throw new Error(
i18n.translate(
'data.search.aggs.paramTypes.field.invalidSavedFieldParameterErrorMessage',
{
defaultMessage:
'Saved field "{fieldParameter}" is invalid for use with the "{aggType}" aggregation. Please select a new field.',
'Saved field "{fieldParameter}" of index pattern "{indexPatternTitle}" is invalid for use with the "{aggType}" aggregation. Please select a new field.',
values: {
fieldParameter: fieldName,
aggType: aggConfig?.type?.title,
indexPatternTitle: aggConfig.getIndexPattern().title,
},
}
)
Expand Down