-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[docs] Convert migration guide to asciidoc #82600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/kibana-platform (Team:Platform) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a lot of comments 😅 but I think it's worth spending a bit of extra effort on these public docs.
docs/developer/architecture/kibana-platform-plugin-api.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/architecture/kibana-platform-plugin-api.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/architecture/kibana-platform-plugin-api.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/architecture/kibana-platform-plugin-api.asciidoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Rudolf Meijering <[email protected]>
Co-authored-by: Rudolf Meijering <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
docs/developer/plugin/migrating-legacy-plugins-examples.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/plugin/migrating-legacy-plugins-examples.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/plugin/migrating-legacy-plugins-examples.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/plugin/migrating-legacy-plugins-examples.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/plugin/migrating-legacy-plugins-examples.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/plugin/migrating-legacy-plugins-examples.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/plugin/migrating-legacy-plugins-examples.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/plugin/migrating-legacy-plugins-examples.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/plugin/migrating-legacy-plugins-examples.asciidoc
Outdated
Show resolved
Hide resolved
docs/developer/plugin/migrating-legacy-plugins-examples.asciidoc
Outdated
Show resolved
Hide resolved
* Initial conversion to asciidoc * Update and split migration guide * Convert MIGRATION_EXAMPLES to asciidoc * build with --focus flag * convert migration guide to asciidoc * cleanup migration_examples * fix wrong Heading size * update links in docs * Apply suggestions from code review Co-authored-by: Rudolf Meijering <[email protected]> * Apply suggestions from code review Co-authored-by: Rudolf Meijering <[email protected]> * add tooling section * explain purpose of each lifecycle method * cleanup docs * cleanup p2 * fix wrong link * resturcture core docs * fix wrong link * update missing links * Apply suggestions from code review Co-authored-by: gchaps <[email protected]> * address comments * add a commenta about plugin-helpers preconfigured * improve density of tables * fix lik * remove links to the migration guide * address comments * Apply suggestions from code review Co-authored-by: gchaps <[email protected]> * address @gchaps comments * Apply suggestions from code review Co-authored-by: gchaps <[email protected]> * change format of ES client change list Co-authored-by: Josh Dover <[email protected]> Co-authored-by: Rudolf Meijering <[email protected]> Co-authored-by: gchaps <[email protected]> # Conflicts: # docs/developer/architecture/core/saved-objects-service.asciidoc # docs/developer/architecture/index.asciidoc # src/core/MIGRATION.md # src/core/README.md
* Initial conversion to asciidoc * Update and split migration guide * Convert MIGRATION_EXAMPLES to asciidoc * build with --focus flag * convert migration guide to asciidoc * cleanup migration_examples * fix wrong Heading size * update links in docs * Apply suggestions from code review Co-authored-by: Rudolf Meijering <[email protected]> * Apply suggestions from code review Co-authored-by: Rudolf Meijering <[email protected]> * add tooling section * explain purpose of each lifecycle method * cleanup docs * cleanup p2 * fix wrong link * resturcture core docs * fix wrong link * update missing links * Apply suggestions from code review Co-authored-by: gchaps <[email protected]> * address comments * add a commenta about plugin-helpers preconfigured * improve density of tables * fix lik * remove links to the migration guide * address comments * Apply suggestions from code review Co-authored-by: gchaps <[email protected]> * address @gchaps comments * Apply suggestions from code review Co-authored-by: gchaps <[email protected]> * change format of ES client change list Co-authored-by: Josh Dover <[email protected]> Co-authored-by: Rudolf Meijering <[email protected]> Co-authored-by: gchaps <[email protected]> # Conflicts: # docs/developer/architecture/core/saved-objects-service.asciidoc # docs/developer/architecture/index.asciidoc # src/core/MIGRATION.md # src/core/README.md
* Initial conversion to asciidoc * Update and split migration guide * Convert MIGRATION_EXAMPLES to asciidoc * build with --focus flag * convert migration guide to asciidoc * cleanup migration_examples * fix wrong Heading size * update links in docs * Apply suggestions from code review Co-authored-by: Rudolf Meijering <[email protected]> * Apply suggestions from code review Co-authored-by: Rudolf Meijering <[email protected]> * add tooling section * explain purpose of each lifecycle method * cleanup docs * cleanup p2 * fix wrong link * resturcture core docs * fix wrong link * update missing links * Apply suggestions from code review Co-authored-by: gchaps <[email protected]> * address comments * add a commenta about plugin-helpers preconfigured * improve density of tables * fix lik * remove links to the migration guide * address comments * Apply suggestions from code review Co-authored-by: gchaps <[email protected]> * address @gchaps comments * Apply suggestions from code review Co-authored-by: gchaps <[email protected]> * change format of ES client change list Co-authored-by: Josh Dover <[email protected]> Co-authored-by: Rudolf Meijering <[email protected]> Co-authored-by: gchaps <[email protected]> # Conflicts: # docs/developer/architecture/core/saved-objects-service.asciidoc # docs/developer/architecture/index.asciidoc # src/core/MIGRATION.md # src/core/README.md
* Initial conversion to asciidoc * Update and split migration guide * Convert MIGRATION_EXAMPLES to asciidoc * build with --focus flag * convert migration guide to asciidoc * cleanup migration_examples * fix wrong Heading size * update links in docs * Apply suggestions from code review Co-authored-by: Rudolf Meijering <[email protected]> * Apply suggestions from code review Co-authored-by: Rudolf Meijering <[email protected]> * add tooling section * explain purpose of each lifecycle method * cleanup docs * cleanup p2 * fix wrong link * resturcture core docs * fix wrong link * update missing links * Apply suggestions from code review Co-authored-by: gchaps <[email protected]> * address comments * add a commenta about plugin-helpers preconfigured * improve density of tables * fix lik * remove links to the migration guide * address comments * Apply suggestions from code review Co-authored-by: gchaps <[email protected]> * address @gchaps comments * Apply suggestions from code review Co-authored-by: gchaps <[email protected]> * change format of ES client change list Co-authored-by: Josh Dover <[email protected]> Co-authored-by: Rudolf Meijering <[email protected]> Co-authored-by: gchaps <[email protected]> # Conflicts: # docs/developer/architecture/core/saved-objects-service.asciidoc # docs/developer/architecture/index.asciidoc # src/core/MIGRATION.md # src/core/README.md
|
The old link should still have a placeholder that link people to the correct place. There are links to the guide in the blog post that explains the new architecture. |
Summary
Closes #75786
This PR: