Merged
Conversation
Contributor
|
This is pretty broken, so perhaps we should finish #8253 before moving to this? |
- splitting it into 3 subclasses (Axis, AxisLabels, AxisScale) - converting to ES6 classes + style fixes - adding more customization options
- allowing handler to have multiple category/value axes (array)
…f axis - updating css min-widths to 1px (removing them breaks the code) as we dont want to reserve the space for axes that dont exist.
ppisljar
force-pushed
the
vislib/axis
branch
from
300dfcc to
727eecc
Compare
Contributor
Author
|
i am not sure what happened, either rebase went wrong or i forgot to commit some parts ... i am working on adding AxisConfig class now. what do you think its better, make it a commit here or should i make it a separate PR ? |
| position: 'left', | ||
| axisFormatter: null, // TODO: create default axis formatter | ||
| scale: 'linear', | ||
| expandLastBucket: true, //TODO: rename ... bucket has nothing to do with vis |
Contributor
|
Alright, changes will be in the AxisConfig pr, and this looks good, so merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replying work from #8174 to the new vislib-axis-refactor branch
i hope its not too messy, but i am guessing you are by now already quite familiar with this code so it might be easiest for both to start from here.
im gonna create a new PR now where i'll add AxisConfig class (to decouple Axis subclasses from Axis itself) which if i understood correcly is the biggest concert with the current implementation.