Skip to content

[Security Solution] Unskips Overview tests #82459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 5, 2020
Merged

[Security Solution] Unskips Overview tests #82459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e425cbc
unskips Overview tests
MadameSheema Nov 3, 2020
e52f7fe
fixes overview tests
MadameSheema Nov 3, 2020
a6e7e65
unskips 'with no data' test
MadameSheema Nov 3, 2020
b7e75e2
fixes 'with no data' test
MadameSheema Nov 4, 2020
101880f
Merge branch 'master' into fix/overview
kibanamachine Nov 4, 2020
91d5cfb
stubs empty instace
MadameSheema Nov 4, 2020
fe4f803
fixes typecheck issue
MadameSheema Nov 4, 2020
f6507fb
fixes hooks issue
MadameSheema Nov 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions x-pack/plugins/security_solution/cypress/fixtures/empty_instance.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"indexFields":[],"indicesExist":[],"rawResponse":{"timed_out":false,"took":-1,"_shards":{"total":-1,"successful":-1,"failed":-1,"skipped":-1},"hits":{"total":-1,"max_score":-1,"hits":[{"_index":"","_type":"","_id":"","_score":-1,"_source":null}]}}}
21 changes: 8 additions & 13 deletions x-pack/plugins/security_solution/cypress/integration/overview.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,11 @@ import { expandHostStats, expandNetworkStats } from '../tasks/overview';
import { loginAndWaitForPage } from '../tasks/login';

import { OVERVIEW_URL } from '../urls/navigation';
import { esArchiverUnload, esArchiverLoad } from '../tasks/es_archiver';

describe.skip('Overview Page', () => {
before(() => {
describe('Overview Page', () => {
it('Host stats render with correct values', () => {
cy.stubSearchStrategyApi('overviewHostQuery', 'overview_search_strategy');
cy.stubSearchStrategyApi('overviewNetworkQuery', 'overview_search_strategy');
loginAndWaitForPage(OVERVIEW_URL);
});

it('Host stats render with correct values', () => {
expandHostStats();

HOST_STATS.forEach((stat) => {
Expand All @@ -28,21 +23,21 @@ describe.skip('Overview Page', () => {
});

it('Network stats render with correct values', () => {
cy.stubSearchStrategyApi('overviewNetworkQuery', 'overview_search_strategy');
loginAndWaitForPage(OVERVIEW_URL);
expandNetworkStats();

NETWORK_STATS.forEach((stat) => {
cy.get(stat.domId).invoke('text').should('eq', stat.value);
});
});

describe.skip('with no data', () => {
describe('with no data', () => {
before(() => {
esArchiverUnload('auditbeat');
cy.server();
cy.fixture('empty_instance').as('emptyInstance');
loginAndWaitForPage(OVERVIEW_URL);
});

after(() => {
esArchiverLoad('auditbeat');
cy.route('POST', '**/internal/search/securitySolutionIndexFields', '@emptyInstance');
});

it('Splash screen should be here', () => {
Expand Down