Skip to content

[TSVB] Disable using top_hits in pipeline aggregations #82278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 10, 2020
Merged

[TSVB] Disable using top_hits in pipeline aggregations #82278

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7185ed0
[TSVB] Disable using top_hits in bucket script aggregations
stratoula Nov 2, 2020
f66a468
remove console message
stratoula Nov 2, 2020
cbcdf25
Merge branch 'master' into disable-bucket-script-tophit
kibanamachine Nov 3, 2020
8044f86
Correct schema for metrics size
stratoula Nov 3, 2020
eb94e8d
Chanhe hardcoded agg with the exported for the METRIC_TYPES var
stratoula Nov 3, 2020
930fd0b
Exclude top_hit agg from all Sibling Pipeline Aggregations and all Pa…
stratoula Nov 3, 2020
cbfa9e6
Merge branch 'master' into disable-bucket-script-tophit
kibanamachine Nov 5, 2020
b8f4f42
Merge branch 'master' into disable-bucket-script-tophit
kibanamachine Nov 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugins/vis_type_timeseries/common/vis_schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export const metricsItems = schema.object({
type: stringRequired,
value: stringOptionalNullable,
values: schema.maybe(schema.nullable(schema.arrayOf(schema.nullable(schema.string())))),
size: stringOptionalNullable,
size: stringOrNumberOptionalNullable,
agg_with: stringOptionalNullable,
order: stringOptionalNullable,
order_by: stringOptionalNullable,
Expand Down
1 change: 1 addition & 0 deletions src/plugins/vis_type_timeseries/public/application/components/aggs/calculation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ export function CalculationAgg(props) {
onChange={handleChange}
name="variables"
model={model}
exclude={['top_hit']}
/>
</EuiFlexItem>

Expand Down
1 change: 1 addition & 0 deletions src/plugins/vis_type_timeseries/public/application/components/aggs/vars.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ export class CalculationVars extends Component {
metric={this.props.model}
value={row.field}
includeSiblings={this.props.includeSiblings}
exclude={this.props.exclude}
/>
</EuiFlexItem>
<EuiFlexItem>
Expand Down