Conversation
--------- **Commit 1:** [optimizer] move to querystring-browser package for up-to-date api Webpack automatically injects libraries to support many node.js APIs in the browser using the https://github.com/webpack/node-libs-browser package. This package uses https://github.com/mike-spainhower/querystring for the querystring module, but that module hasn't been updated in 4 years and doesn't support the modern querystring api. This change points to the https://github.com/mathiasvr/querystring package instead, which is up to date (specifically it supports the `encodeURIComponent` option of [`querystring.stringify`](https://nodejs.org/api/querystring.html#querystring_querystring_stringify_obj_sep_eq_options). * Original sha: 1030689 * Authored by spalger <spalger@users.noreply.github.com> on 2016-09-09T21:10:50Z
epixa
changed the title
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[backport] PR elastic#8209 to 5.x - [optimizer] move to querystring-browser package for up-to-date api Former-commit-id: b717844
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport PR #8209
Commit 1:
[optimizer] move to querystring-browser package for up-to-date api
Webpack automatically injects libraries to support many node.js APIs in the browser using the https://github.com/webpack/node-libs-browser package. This package uses https://github.com/mike-spainhower/querystring for the querystring module, but that module hasn't been updated in 4 years and doesn't support the modern querystring api.
This change points to the https://github.com/mathiasvr/querystring package instead, which is up to date (specifically it supports the
encodeURIComponentoption ofquerystring.stringify.