Skip to content

[Graph] Fix problem with duplicate ids #82109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2020
Merged

[Graph] Fix problem with duplicate ids #82109

merged 1 commit into from
Oct 30, 2020

Conversation

@stratoula
Copy link
Contributor

@stratoula stratoula commented Oct 30, 2020 •
edited
Loading

Summary

Closes #75211

There was the accessibility problem with duplicate ids in graph plugin. It has been solved by adding the field name in the id.

Screenshot 2020-10-30 at 11 48 20 AM

@timroes timroes added v7.11.0 and removed v7.11 labels Oct 30, 2020
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 30, 2020

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
graph 1.3MB 1.3MB +27.0B

Saved Objects .kibana field count

id before after diff
_data_stream_timestamp - 1 +1
action - 5 +5
action_task_params - 3 +3
alert - 30 +30
apm-indices - 8 +8
application_usage_daily - 2 +2
canvas-element - 8 +8
canvas-workpad - 5 +5
canvas-workpad-template - 8 +8
cases - 38 +38
cases-comments - 17 +17
cases-configure - 19 +19
cases-user-actions - 10 +10
config - 2 +2
dashboard - 17 +17
endpoint:user-artifact - 10 +10
endpoint:user-artifact-manifest - 5 +5
epm-packages - 15 +15
exception-list - 39 +39
exception-list-agnostic - 39 +39
file-upload-telemetry - 2 +2
fleet-agent-actions - 9 +9
fleet-agent-events - 11 +11
fleet-agents - 25 +25
fleet-enrollment-api-keys - 10 +10
graph-workspace - 9 +9
index-pattern - 3 +3
ingest_manager_settings - 6 +6
ingest-agent-policies - 11 +11
ingest-outputs - 11 +11
ingest-package-policies - 35 +35
kql-telemetry - 3 +3
lens - 7 +7
lens-ui-telemetry - 5 +5
map - 7 +7
ml-telemetry - 3 +3
monitoring-telemetry - 2 +2
namespace - 1 +1
namespaces - 1 +1
originId - 1 +1
query - 6 +6
references - 4 +4
sample-data-telemetry - 3 +3
search - 9 +9
siem-detection-engine-rule-actions - 8 +8
siem-detection-engine-rule-status - 12 +12
siem-ui-timeline - 90 +90
siem-ui-timeline-note - 8 +8
siem-ui-timeline-pinned-event - 7 +7
space - 9 +9
telemetry - 9 +9
timelion-sheet - 13 +13
tsvb-validation-telemetry - 2 +2
type - 1 +1
ui-metric - 2 +2
updated_at - 1 +1
upgrade-assistant-reindex-operation - 18 +18
upgrade-assistant-telemetry - 13 +13
url - 6 +6
visualization - 9 +9
total +673

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula marked this pull request as ready for review October 30, 2020 11:43
@stratoula stratoula requested a review from a team October 30, 2020 11:43
@stratoula stratoula added the Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// label Oct 30, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 30, 2020

Pinging @elastic/kibana-app (Team:KibanaApp)

flash1293
flash1293 approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and still works as expected, thanks!

@stratoula stratoula merged commit 415a063 into elastic:master Oct 30, 2020
stratoula added a commit to stratoula/kibana that referenced this pull request Oct 30, 2020
@stratoula
[Graph] Fix problem with duplicate ids (elastic#82109)
81aa5e8
@stratoula stratoula mentioned this pull request Oct 30, 2020
Merged
stratoula added a commit that referenced this pull request Oct 30, 2020
@stratoula
[Graph] Fix problem with duplicate ids (#82109) (#82131)
aa1688c
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 30, 2020
@gmmorris
Merge branch 'master' into alerts/convert-to-tm-intervals
1929b5d 
* master: (71 commits)
  [Chrome] Extension to append an element to the last breadcrumb (elastic#82015)
  [Monitoring] Thread pool rejections alert (elastic#79433)
  [Actions] Fix actionType type on registerType function (elastic#82125)
  [Security Solution] Modal for saving timeline (elastic#81802)
  add tests for index pattern switching (elastic#81987)
  TS project references for share plugin (elastic#82051)
  [Graph] Fix problem with duplicate ids (elastic#82109)
  skip 'returns a single bucket if array has 1'.  related elastic#81460
  Add a link to documentation in the alerts and actions management UI (elastic#81909)
  [Fleet] fix duplicate ingest pipeline refs (elastic#82078)
  Context menu trigger for URL Drilldown (elastic#81158)
  SO management: fix legacy import index pattern selection being reset when switching page (elastic#81621)
  Fixed dead links (elastic#78696)
  [Search] Add "restore" to session service (elastic#81924)
  fix Lens heading structure (elastic#81752)
  [ML] Data Frame Analytics: Fix feature importance cell value and decision path chart (elastic#82011)
  Remove legacy app arch items from codeowners. (elastic#82084)
  [TSVB] Renamed 'positive rate' to 'counter rate' (elastic#80939)
  Expressions/migrations2 (elastic#81281)
  [Telemetry] [Schema] remove number type and support all es number types (elastic#81774)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees

No one assigned

Labels

Feature:Graph Graph application feature Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.11.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(Accessibility) Graph - Duplicate ID's

5 participants

@stratoula @kibanamachine @elasticmachine @flash1293 @timroes