Skip to content

Properly handle session index initialization failures. #81894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2020
Merged

Properly handle session index initialization failures. #81894

merged 1 commit into from
Oct 29, 2020

Conversation

@azasypkin
Copy link
Member

@azasypkin azasypkin commented Oct 28, 2020 •
edited
Loading

In this PR we handle any unexpected errors thrown inside of a Promise executor with reject that'll prevent unhandled promise rejections.

Fixes: #81777

@azasypkin azasypkin added Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// Feature:Security/Authentication Platform Security - Authentication release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.11.0 labels Oct 28, 2020
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 28, 2020

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@azasypkin azasypkin marked this pull request as ready for review October 28, 2020 14:07
@azasypkin azasypkin requested a review from a team as a code owner October 28, 2020 14:07
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 28, 2020

Pinging @elastic/kibana-security (Team:Security)

@azasypkin azasypkin requested a review from legrego October 28, 2020 14:07
legrego
legrego approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@azasypkin azasypkin merged commit 213469d into elastic:master Oct 29, 2020
@azasypkin azasypkin deleted the issue-81777-unresolved-promise branch October 29, 2020 09:56
This was referenced Oct 29, 2020
Merged
Merged
azasypkin added a commit to azasypkin/kibana that referenced this pull request Oct 29, 2020
@azasypkin
Properly handle session index initialization failures. (elastic#81894)
44ff01e
@azasypkin
Copy link
Member Author

azasypkin commented Oct 29, 2020

7.10/7.10.0: 2734278
7.x/7.11.0: 233a3e3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legrego legrego legrego approved these changes

Assignees

No one assigned

Labels

backported Feature:Security/Authentication Platform Security - Authentication release_note:skip Skip the PR/issue when compiling release notes Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v7.10.0 v7.11.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Errors thrown during session index initialization result in unhandled promise rejections

4 participants

@azasypkin @kibanamachine @elasticmachine @legrego