removing extra legend div from pie chart#8175
Merged
ppisljar merged 2 commits intoelastic:masterfrom Sep 13, 2016
Merged
Conversation
(seems like a left over from old times)
Contributor
|
This fixes the issue that I raised.
|
Contributor
|
Also, on a related note, I don't think this was introduced by your changes, but should the collapse/expand button for the legend be visible when the panel does not have focus? Looks like we were trying to hide all widgets of a panel when it doesn't have focus. |
Contributor
|
I can reproduce the scrollbar issue on:
but NOT on Firefox (firefox left, Edge right) |
| .vis-container--legend-bottom & { | ||
| width: auto; | ||
| overflow-y: hidden; | ||
|
|
Contributor
There was a problem hiding this comment.
works good, also with long legends.
Contributor
|
LGTM. As for hiding the expando-button when there's no focus, I agree that that's a separate issue. |
Contributor
|
LGTM |
elastic-jasper
added a commit
that referenced
this pull request
Sep 13, 2016
--------- **Commit 1:** removing extra legend div from pie chart (seems like a left over from old times) * Original sha: ef97965 * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-07T07:47:40Z **Commit 2:** fixing issue with scrollbars * Original sha: 91a8c4b * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-07T17:47:30Z
elastic-jasper
added a commit
that referenced
this pull request
Sep 13, 2016
--------- **Commit 1:** removing extra legend div from pie chart (seems like a left over from old times) * Original sha: ef97965 * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-07T07:47:40Z **Commit 2:** fixing issue with scrollbars * Original sha: 91a8c4b * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-07T17:47:30Z
This was referenced Sep 13, 2016
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
--------- **Commit 1:** removing extra legend div from pie chart (seems like a left over from old times) * Original sha: 202006606049998a9fc98a86c5602dc18f63648c [formerly ef97965] * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-07T07:47:40Z **Commit 2:** fixing issue with scrollbars * Original sha: 5cb43d3a824b64fb5d723ef4bc74d7b30719a64a [formerly 91a8c4b] * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-09-07T17:47:30Z Former-commit-id: 3205134
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[backport] PR elastic#8175 to 5.x Former-commit-id: de691d7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8165
in pie chart layout there was an extra legend div. seems like leftover from old times as now the legend is separated from the chart.