[Feature:Resolver] enable_APM-ci branch fixes #81658

IgorGuz2000 · 2020-10-26T18:38:59Z

Summary

This is the fix to Pass enable_APM-ci branch
#80399

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

…ents_resolver

elasticmachine · 2020-10-26T18:39:02Z

Pinging @elastic/datavis (Team:DataVis)

tylersmalley · 2020-10-26T21:37:49Z

I will be testing against the changes here once they go into master.

tylersmalley · 2020-10-26T22:43:12Z

@elasticmachine merge upstream

tylersmalley · 2020-10-27T05:47:30Z

I opened a draft PR to test these changes with enabling APM collection in Kibana here: #81695

Still seeing the following error (log):

17:02:42               └-> Check Related Events for event.file Node
17:02:42                 └-> "before each" hook: global before each
17:02:54                 └- ✖ fail: endpoint Endpoint Event Resolver Endpoint Resolver Tree Check Related Events for event.file Node
17:02:54                 │      Error: expected '17 authentication' to equal 'Events'
17:02:54                 │       at Assertion.assert (/dev/shm/workspace/parallel/21/kibana/packages/kbn-expect/expect.js:100:11)
17:02:54                 │       at Assertion.equal (/dev/shm/workspace/parallel/21/kibana/packages/kbn-expect/expect.js:227:8)
17:02:54                 │       at Object.runNodeEvents (test/security_solution_endpoint/page_objects/hosts_page.ts:127:30)
17:02:54                 │       at process._tickCallback (internal/process/next_tick.js:68:7)

markov00 · 2020-10-27T08:33:49Z

I've removed the DataVis team label as it doesn't seem to belong to our team, @IgorGuz2000 please fix that if I'm wrong

elasticmachine · 2020-10-27T21:14:20Z

Pinging @elastic/endpoint-app-team (Feature:Resolver)

charlie-pichette

I would be nice to have an explanation of why this change is needed, but the change is ok.

charlie-pichette · 2020-10-28T17:23:07Z

x-pack/test/security_solution_endpoint/apps/endpoint/resolver.ts

        await pageObjects.hosts.executeQueryAndOpenResolver(
          'event.dataset : endpoint.events.library'
        );
+        for (let i = 0; i < 7; i++) {


A comment would be nice to explain why we are clicking west 7 times.

achuguy · 2020-10-28T20:18:46Z

x-pack/test/security_solution_endpoint/apps/endpoint/resolver.ts

+          '1 session',
+          '329 network',
+          '1 library',
+          '1 library',


Should there be 2 separate library events in this list?

What you mean
Yes this is what it looks like

tylersmalley · 2020-10-28T22:39:17Z

@IgorGuz2000 as mentioned here. I am still seeing the error when APM is enabled suggesting there is still possibly a timing issue.

I opened a new draft to test against the recent changes and still seeing the same:

14:28:10       │1)    endpoint
14:28:10       │       Endpoint Event Resolver
14:28:10       │         Endpoint Resolver Tree
14:28:10       │           Check Related Events for event.file Node:
14:28:10       │
14:28:10       │      Error: expected '17 authentication' to equal 'Events'
14:28:10       │       at Assertion.assert (/dev/shm/workspace/parallel/15/kibana/packages/kbn-expect/expect.js:100:11)
14:28:10       │       at Assertion.equal (/dev/shm/workspace/parallel/15/kibana/packages/kbn-expect/expect.js:227:8)
14:28:10       │       at Object.runNodeEvents (test/security_solution_endpoint/page_objects/hosts_page.ts:127:30)
14:28:10       │       at process._tickCallback (internal/process/next_tick.js:68:7)

kibanamachine · 2020-10-30T21:04:39Z