Skip to content

[Monitoring] Unskip test #81568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2020
Merged

[Monitoring] Unskip test #81568

merged 2 commits into from
Oct 26, 2020

Conversation

@chrisronline
Copy link
Contributor

@chrisronline chrisronline commented Oct 23, 2020

Unskips test with #81166 (comment)

#81200 should have fixed the issue

@chrisronline chrisronline added review Team:Monitoring Stack Monitoring team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.11.0 labels Oct 23, 2020
@chrisronline chrisronline self-assigned this Oct 23, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 23, 2020

Pinging @elastic/stack-monitoring (Team:Monitoring)

@chrisronline chrisronline requested a review from a team October 23, 2020 18:32
igoristic
igoristic approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 tests are passing now

@chrisronline
Copy link
Contributor Author

chrisronline commented Oct 26, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 26, 2020

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline chrisronline merged commit ac640f1 into elastic:master Oct 26, 2020
@chrisronline chrisronline deleted the monitoring/unskip_test branch October 26, 2020 17:13
chrisronline added a commit to chrisronline/kibana that referenced this pull request Oct 26, 2020
@chrisronline @kibanamachine
Unskip test (elastic#81568)
003832d 
Co-authored-by: Kibana Machine <[email protected]>
@chrisronline chrisronline mentioned this pull request Oct 26, 2020
Merged
chrisronline added a commit to chrisronline/kibana that referenced this pull request Oct 26, 2020
@chrisronline @kibanamachine
Unskip test (elastic#81568)
00462c0 
Co-authored-by: Kibana Machine <[email protected]>
@chrisronline chrisronline mentioned this pull request Oct 26, 2020
Merged
chrisronline added a commit that referenced this pull request Oct 26, 2020
@chrisronline @kibanamachine
Unskip test (#81568) (#81647)
6e0e08c 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
chrisronline added a commit that referenced this pull request Oct 26, 2020
@chrisronline @kibanamachine
Unskip test (#81568) (#81646)
584bb3a 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
@chrisronline
Copy link
Contributor Author

chrisronline commented Oct 26, 2020

Backport:

7.10: 6e0e08c
7.x: 584bb3a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@igoristic igoristic igoristic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chrisronline chrisronline

Labels

release_note:skip Skip the PR/issue when compiling release notes review Team:Monitoring Stack Monitoring team v7.10.0 v7.11.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chrisronline @elasticmachine @kibanamachine @igoristic