Merged
Conversation
Author
|
Hold off on this PR. I think I missed checking part of it in. |
…tting line chart data
|
|
||
| bdd.it('should show correct chart order by Term', function pageHeader() { | ||
|
|
||
| var remote = this.remote; |
Contributor
There was a problem hiding this comment.
I don't think remote is used lower down this scope.
Author
|
Jenkins, test this |
| return PageObjects.visualize.selectOrderBy('_term') | ||
| .then(function clickGo() { | ||
| return PageObjects.visualize.clickGo(); | ||
| }) |
Contributor
There was a problem hiding this comment.
Any reason not to pass a direct reference to clickGo here?
.then(PageObjects.visualize.clickGo)
Contributor
|
Just had some minor readability suggestions. LGTM otherwise! |
Author
|
I removed all those bogus pageHeader function names (just left them anonymous now). I didn't make any other changes like precomputing the expectedChartY values. I'd like to keep this PR limited to adding this one test for the escaped bug. |
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Test order aggs by term elastic#8141 Former-commit-id: 1cebdd7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a test to _line_chart.js that changes the default order by from count to term.
'should show correct chart order by Term'
Passes on master (5.0). I assume this is going to fail on 4.6.0, and then pass on 4.6.1 but I haven't tried either yet.