explicitly export core mock types #81527
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
chore
v8.0.0
release_note:skip
Contributor
Author
|
FYI @elastic/kibana-operations |
Contributor
|
I really hate globals, is it really too much to ask that these types get imported everywhere they are used? |
Contributor
Author
@spalger probably it's okay...also we could try to include them automatically for all the TS project (with https://www.typescriptlang.org/tsconfig#typeRoots in |
Contributor
Sounds like another way to add more globals. |
mshustov
force-pushed
the
export-mock-types
branch
from
1004fc0 to
d8760f0
Compare
Contributor
Contributor
Author
|
closed in favour of #81739 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes build error https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/83411/execution/node/105/log/ in #81177
Other TS project configs include 'global'
typingskibana/src/plugins/kibana_react/tsconfig.json
Line 12 in ae8f8e1
Which shouldn't be a requirement for them. It's rather a temporary workaround. In the ideal case, we should import all global types explicitly from
@kbn/utility-types. Unfortunately, I didn't manage to find a way to movejest.Mockedtype there #76785 (comment)@mistic Can it be a problem for the migration to the Bazel toolchain?