Skip to content

[ML] Fixing exclude frequent in advanced wizard #81121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 20, 2020
Merged

[ML] Fixing exclude frequent in advanced wizard #81121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea22c29
[ML] Fixing exclude frequent in advanced wizard
jgowdyelastic Oct 20, 2020
f07fd63
updating description
jgowdyelastic Oct 20, 2020
018d118
adding exclude_frequent to test
jgowdyelastic Oct 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...omponents/pick_fields_step/components/advanced_detector_modal/advanced_detector_modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,12 @@ const emptyOption: EuiComboBoxOptionOption = {
label: '',
};

const excludeFrequentOptions: EuiComboBoxOptionOption[] = [{ label: 'all' }, { label: 'none' }];
const excludeFrequentOptions: EuiComboBoxOptionOption[] = [
{ label: 'all' },
{ label: 'none' },
{ label: 'by' },
{ label: 'over' },
];

export const AdvancedDetectorModal: FC<Props> = ({
payload,
Expand Down
2 changes: 1 addition & 1 deletion ...job/pages/components/pick_fields_step/components/advanced_detector_modal/descriptions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ export const ExcludeFrequentDescription: FC = memo(({ children }) => {
description={
<FormattedMessage
id="xpack.ml.newJob.wizard.pickFieldsStep.advancedDetectorModal.excludeFrequent.description"
defaultMessage="If true will automatically identify and exclude frequently occurring entities which may otherwise have dominated results."
defaultMessage="If set, it will automatically identify and exclude frequently occurring entities which may otherwise have dominated results."
/>
}
>
Expand Down
2 changes: 2 additions & 0 deletions x-pack/plugins/ml/server/routes/schemas/anomaly_detectors_schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ const detectorSchema = schema.object({
over_field_name: schema.maybe(schema.string()),
partition_field_name: schema.maybe(schema.string()),
detector_description: schema.maybe(schema.string()),
exclude_frequent: schema.maybe(schema.string()),
use_null: schema.maybe(schema.boolean()),
/** Custom rules */
custom_rules: customRulesSchema,
});
Expand Down
8 changes: 7 additions & 1 deletion x-pack/test/api_integration/apis/ml/job_validation/validate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,13 @@ export default ({ getService }: FtrProviderContext) => {
groups: [],
analysis_config: {
bucket_span: '15m',
detectors: [{ function: 'mean', field_name: 'products.discount_amount' }],
detectors: [
{
function: 'mean',
field_name: 'products.discount_amount',
exclude_frequent: 'none',
},
],
influencers: [],
summary_count_field_name: 'doc_count',
},
Expand Down