Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
7702b95
obs perf
cauemarcondes Oct 15, 2020
5afc484
fixing unit tests
cauemarcondes Oct 15, 2020
0dd4a60
fixing ts issues
cauemarcondes Oct 15, 2020
f35e2c0
fixing empty state
cauemarcondes Oct 15, 2020
38a67b9
Merge branch 'master' into obs-improve-perf
kibanamachine Oct 17, 2020
d37c788
addressing pr comments
cauemarcondes Oct 19, 2020
e5b149b
addressing pr comments
cauemarcondes Oct 19, 2020
af22249
fixing TS issue
cauemarcondes Oct 19, 2020
21ed767
Merge branch 'master' of github.com:elastic/kibana into obs-improve-perf
cauemarcondes Nov 2, 2020
94eb333
Merge branch 'master' of github.com:elastic/kibana into obs-improve-perf
cauemarcondes Nov 2, 2020
7ba1593
fixing some stuff
cauemarcondes Nov 2, 2020
f4f2502
Merge branch 'master' of github.com:elastic/kibana into obs-improve-perf
cauemarcondes Nov 3, 2020
3f3fdd9
refactoring
cauemarcondes Nov 5, 2020
97be452
fixing ts issues and unit tests
cauemarcondes Nov 5, 2020
88fd2e4
Merge branch 'master' into obs-improve-perf
kibanamachine Nov 5, 2020
77b993a
Merge branch 'master' of github.com:elastic/kibana into obs-improve-perf
cauemarcondes Nov 20, 2020
c7a12d6
Merge branch 'obs-improve-perf' of github.com:cauemarcondes/kibana in…
cauemarcondes Nov 20, 2020
4f0332d
addressing PR comments
cauemarcondes Nov 20, 2020
bf819f8
fixing TS issues
cauemarcondes Nov 20, 2020
6d8a567
fixing eslint issue
cauemarcondes Nov 20, 2020
080edfe
Merge branch 'master' into obs-improve-perf
kibanamachine Nov 23, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
FetchDataParams,
HasDataParams,
UxFetchDataResponse,
UXHasDataResponse,
} from '../../../../../observability/public/';
import { callApmApi } from '../../../services/rest/createCallApmApi';

Expand Down Expand Up @@ -35,7 +36,9 @@ export const fetchUxOverviewDate = async ({
};
};

export async function hasRumData({ absoluteTime }: HasDataParams) {
export async function hasRumData({
absoluteTime,
}: HasDataParams): Promise<UXHasDataResponse> {
return await callApmApi({
pathname: '/api/apm/observability_overview/has_rum_data',
params: {
Expand Down
11 changes: 2 additions & 9 deletions x-pack/plugins/infra/public/utils/logs_overview_fetchers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,7 @@

import { encode } from 'rison-node';
import { SearchResponse } from 'elasticsearch';
import {
FetchData,
FetchDataParams,
HasData,
LogsFetchDataResponse,
} from '../../../observability/public';
import { FetchData, FetchDataParams, LogsFetchDataResponse } from '../../../observability/public';
import { DEFAULT_SOURCE_ID } from '../../common/constants';
import { callFetchLogSourceConfigurationAPI } from '../containers/logs/log_source/api/fetch_log_source_configuration';
import { callFetchLogSourceStatusAPI } from '../containers/logs/log_source/api/fetch_log_source_status';
Expand All @@ -38,9 +33,7 @@ interface LogParams {

type StatsAndSeries = Pick<LogsFetchDataResponse, 'stats' | 'series'>;

export function getLogsHasDataFetcher(
getStartServices: InfraClientCoreSetup['getStartServices']
): HasData {
export function getLogsHasDataFetcher(getStartServices: InfraClientCoreSetup['getStartServices']) {
return async () => {
const [core] = await getStartServices();
const sourceStatus = await callFetchLogSourceStatusAPI(DEFAULT_SOURCE_ID, core.http.fetch);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@ describe('renderApp', () => {
it('renders', async () => {
const plugins = ({
usageCollection: { reportUiStats: () => {} },
data: {
query: {
timefilter: {
timefilter: { setTime: jest.fn(), getTime: jest.fn().mockImplementation(() => ({})) },
},
},
},
} as unknown) as ObservabilityPluginSetupDeps;
const core = ({
application: { currentAppId$: new Observable(), navigateToUrl: () => {} },
Expand Down
7 changes: 5 additions & 2 deletions x-pack/plugins/observability/public/application/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import { usePluginContext } from '../hooks/use_plugin_context';
import { useRouteParams } from '../hooks/use_route_params';
import { Breadcrumbs, routes } from '../routes';
import { ObservabilityPluginSetupDeps } from '../plugin';
import { HasDataContextProvider } from '../context/has_data_context';

const observabilityLabelBreadcrumb = {
text: i18n.translate('xpack.observability.observability.breadcrumb.', {
Expand Down Expand Up @@ -45,7 +46,7 @@ function App() {
core.chrome.docTitle.change(getTitleFromBreadCrumbs(breadcrumb));
}, [core, breadcrumb]);

const { query, path: pathParams } = useRouteParams(route.params);
const { query, path: pathParams } = useRouteParams(path);
return route.handler({ query, path: pathParams });
};
return <Route key={path} path={path} exact={true} component={Wrapper} />;
Expand All @@ -70,7 +71,9 @@ export const renderApp = (
<EuiThemeProvider darkMode={isDarkMode}>
<i18nCore.Context>
<RedirectAppLinks application={core.application}>
<App />
<HasDataContextProvider>
<App />
</HasDataContextProvider>
</RedirectAppLinks>
</i18nCore.Context>
</EuiThemeProvider>
Expand Down
Loading