[Timelion] Move the local menu to the header #80627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
stratoula
added
Feature:Timelion
Contributor
Author
|
@elasticmachine merge upstream |
cchaos
approved these changes
Oct 15, 2020
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
Screenshot LGTM, didn't test locally.
stratoula
added
the
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
History
To update your PR or re-run it, just comment with: |
kertal
approved these changes
Oct 19, 2020
Member
kertal
left a comment
kertal
left a comment
There was a problem hiding this comment.
Code LGTM 👍 , tested in Firefox, Chrome, Safari. works
Contributor
Author
|
Thank you @kertal 🚀 |
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Oct 19, 2020
* [Timelion] Move the local menu to the header * nice improvement * remove console msg * cleanup Co-authored-by: Kibana Machine <[email protected]>
stratoula
added a commit
that referenced
this pull request
Oct 19, 2020
* [Timelion] Move the local menu to the header * nice improvement * remove console msg * cleanup Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #80620. It moves the timelion menu to the header in order to be aligned with the other plugins.