Skip to content

[Enterprise Search] Added an EuiEmptyState to Credentials page #2 #80034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 19, 2020
Merged

[Enterprise Search] Added an EuiEmptyState to Credentials page #2 #80034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6eb5250
Added an EuiEmptyState to Credentials
JasonStoltz Oct 5, 2020
3d48430
Moved return
JasonStoltz Oct 19, 2020
d52131d
Reworded message
JasonStoltz Oct 19, 2020
1d0cfb7
Merge branch 'master' into JasonStoltz/empty-state
JasonStoltz Oct 19, 2020
a6be4b2
Return ternary
JasonStoltz Oct 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions ...applications/app_search/components/credentials/credentials_list/credentials_list.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import React from 'react';
import { shallow } from 'enzyme';

import { CredentialsList } from './credentials_list';
import { EuiBasicTable, EuiCopy } from '@elastic/eui';
import { EuiBasicTable, EuiCopy, EuiEmptyPrompt } from '@elastic/eui';
import { IApiToken } from '../types';
import { ApiTokenTypes } from '../constants';

Expand All @@ -26,7 +26,7 @@ describe('Credentials', () => {

// Kea mocks
const values = {
apiTokens: [],
apiTokens: [apiToken],
meta: {
page: {
current: 1,
Expand Down Expand Up @@ -78,6 +78,19 @@ describe('Credentials', () => {
});
});

describe('empty state', () => {
it('renders an EuiEmptyState when no credentials are available', () => {
setMockValues({
...values,
apiTokens: [],
});

const wrapper = shallow(<CredentialsList />);
expect(wrapper.exists(EuiEmptyPrompt)).toBe(true);
expect(wrapper.exists(EuiBasicTable)).toBe(false);
});
});

describe('pagination', () => {
it('derives pagination from meta object', () => {
setMockValues({
Expand Down
24 changes: 22 additions & 2 deletions ...blic/applications/app_search/components/credentials/credentials_list/credentials_list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,13 @@
*/

import React, { useMemo } from 'react';
import { EuiBasicTable, EuiBasicTableColumn, EuiButtonIcon, EuiCopy } from '@elastic/eui';
import {
EuiBasicTable,
EuiBasicTableColumn,
EuiButtonIcon,
EuiCopy,
EuiEmptyPrompt,
} from '@elastic/eui';
import { CriteriaWithPagination } from '@elastic/eui/src/components/basic_table/basic_table';
import { useActions, useValues } from 'kea';

Expand Down Expand Up @@ -118,7 +124,21 @@ export const CredentialsList: React.FC = () => {
fetchCredentials(current + 1);
};

return (
return items.length < 1 ? (
<EuiEmptyPrompt
iconType="editorStrike"
title={
<h2>
{i18n.translate('xpack.enterpriseSearch.appSearch.credentials.empty.title', {
defaultMessage: 'No API Keys have been created yet.',
})}
</h2>
}
body={i18n.translate('xpack.enterpriseSearch.appSearch.credentials.empty.body', {
defaultMessage: 'Click the "Create a key" button to make your first one.',
})}
/>
) : (
<EuiBasicTable
columns={columns}
items={items}
Expand Down