Skip to content

Fix hint for analyzed fields #7993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spalger merged 3 commits into from
Aug 19, 2016
Merged

Fix hint for analyzed fields #7993

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43f9665
Fix hint for analyzed fields
timroes Aug 12, 2016
8c9a81c
Add .raw hint and change wording slightly
timroes Aug 15, 2016
0771be5
Fixed typo in analyzed field hint
timroes Aug 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/ui/public/agg_types/controls/field.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,15 @@
</span>
<div class="hintbox" ng-show="showAnalyzedFieldWarning && agg.params.field.analyzed">
<p>
<strong>Careful!</strong> The field selected contains analyzed strings. Analyzed strings are highly unique and can use a lot of memory to visualize. Values such as <i>foo-bar</i> will be broken into <i>foo</i> and <i>bar</i>. See <a href="http://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-types.html" target="_blank">Mapping Types</a> for more information on setting this field as <i>not_analyzed</i>
<strong>Careful!</strong> The field selected contains analyzed strings. Analyzed strings are highly unique and can use a lot of memory to visualize. Values such as <i>foo-bar</i> will be broken into <i>foo</i> and <i>bar</i>. See <a href="http://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-types.html" target="_blank">Mapping Types</a> for more information on setting this field as <i>keyword</i> (not analyzed).
</p>

<p ng-show="indexedFields.byName[agg.params.field.name + '.keyword'].analyzed == false">
<strong>Tip:</strong> <i>{{agg.params.field.name + '.keyword'}}</i> may be a non analyzed version of this field.
Copy link
Copy Markdown
Contributor

@Bargs Bargs Aug 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth checking for either .raw or .keyword. The .raw suffix will die out eventually, but I think it'll still be pretty prevalent for awhile.

Copy link
Copy Markdown
Contributor Author

@timroes timroes Aug 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you just make two ifs, and if both fields would exist should show two tips below each other? Or would you try to get this into one hint mentioning "either the keyword or raw field.." which would give kind of better usability, but make that code part (for a simple hint) more complex.

Copy link
Copy Markdown
Contributor

@Bargs Bargs Aug 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm I hadn't considered the case where there's both a .raw and .keyword. I think two separate tips is probably fine, but I might have to how it looks on the page to be sure.

</p>

<p ng-show="indexedFields.byName[agg.params.field.name + '.raw'].analyzed == false">
<strong>Tip:</strong> <i>{{agg.params.field.name + '.raw'}}</i> may be a <i>not_analyzed</i> version of this field.
<strong>Tip:</strong> <i>{{agg.params.field.name + '.raw'}}</i> may be a non analyzed version of this field.
</p>
</div>

Expand Down