[Ingest Manager] send protocol separately to agent as part of full agent policy #79781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neptunian
added
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
kevinlog
approved these changes
Oct 6, 2020
jen-huang
approved these changes
Oct 6, 2020
Contributor
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
neptunian
added a commit
to neptunian/kibana
that referenced
this pull request
Oct 6, 2020
neptunian
added a commit
that referenced
this pull request
Oct 7, 2020
jfsiii
reviewed
Oct 14, 2020
| throw new Error('kibana_urls is missing'); | ||
| const hostsWithoutProtocol = settings.kibana_urls.map((url) => { | ||
| const parsedURL = new URL(url); | ||
| return `${parsedURL.host}${parsedURL.pathname !== '/' ? parsedURL.pathname : ''}`; |
Contributor
There was a problem hiding this comment.
@neptunian I'm not sure why this uses pathname in addition to host? Isn't host (hostname + port) enough? I believe it would match the examples added in the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #79740
Summary
When the policy change is sent to the Elastic Agent it includes the
fleet.kibana.hostswith the hosts having a prefix ofhttp://. It should not send it in this format as that doesn't follow the same format shared by all beats.It should send the hosts as:
It is currently sent as:
Change
Separate the host from the url during creation of the full agent policy