-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Maps] Use default format when proxying EMS-files #79760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
thomasneirynck
merged 10 commits into
elastic:master
from
thomasneirynck:maps/proxied_format
Oct 27, 2020
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d5fc9ab
use default format
thomasneirynck 4bd8d11
add functional test (tbd)
thomasneirynck 6e7a9ad
add server flag
thomasneirynck 9a47be6
Merge branch 'master' into maps/proxied_format
kibanamachine b2d76a3
add api test file
thomasneirynck 5664f3c
Merge branch 'maps/proxied_format' of github.com:thomasneirynck/kiban…
thomasneirynck 5d68ad0
Merge branch 'master' into maps/proxied_format
kibanamachine 5cd0147
Merge branch 'master' into maps/proxied_format
kibanamachine 1cc973a
Merge branch 'master' of github.com:elastic/kibana into maps/proxied_…
thomasneirynck d0740e2
make tests more robust
thomasneirynck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License; | ||
| * you may not use this file except in compliance with the Elastic License. | ||
| */ | ||
|
|
||
| import expect from '@kbn/expect'; | ||
|
|
||
| export default function ({ getService }) { | ||
| const supertest = getService('supertest'); | ||
|
|
||
| describe('EMS proxy', () => { | ||
| it('should correctly rewrite url and format', async () => { | ||
| const resp = await supertest | ||
| .get(`/api/maps/ems/files/v7.10/manifest`) | ||
| .set('kbn-xsrf', 'kibana') | ||
| .expect(200); | ||
|
|
||
| expect(resp.body.layers.length).to.be(66); | ||
|
|
||
| //Check world-layer | ||
| const worldLayer = resp.body.layers.find((layer) => layer.layer_id === 'world_countries'); | ||
| expect(worldLayer.formats.length).to.be(1); | ||
thomasneirynck marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| expect(worldLayer.formats[0].type).to.be('geojson'); | ||
| expect(worldLayer.formats[0].url).to.be('file?id=world_countries'); | ||
| }); | ||
| }); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.