Closed
Conversation
Contributor
|
Can one of the admins verify this patch? |
Contributor
|
jenkins, test this |
Contributor
|
LGTM, tests are blocked on #7959. Once that's in I'll give this another run. |
Contributor
|
Thanks @timroes! |
Contributor
|
LGTM as well once tests pass. @jbudz this probably just needs rebased on master now right? |
Contributor
|
Yep that should work. |
Contributor
|
jenkins, test this |
Contributor
|
@timroes I think this still needs to be rebased on master to get the tests passing |
Contributor
|
@timroes I'm going to close this and reopen with your commit rebased off master so we can get CI green. Will link back here. |
jbudz
added a commit
that referenced
this pull request
Aug 19, 2016
Rebase #7952, skip empty lines when parsing CSV
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Rebase elastic#7952, skip empty lines when parsing CSV Former-commit-id: bfaa3d4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CSV importer currently doesn't ignore empty lines when parsing the CSV on the clientside.
Since a) the API does ignore empty lines as it seems from
kibana/src/core_plugins/kibana/server/routes/api/ingest/register_data.js
Line 31 in 37cc438
\nat the end of the file (which currently causes the CSV importer to fail), this should be fixed I think.So this pull request also skip empty lines in the CSV when importing files in the frontend, so these files can at all pass the first wizard step and make it to the backend.