Skip to content

Conversation

@cee-chen
Copy link
Contributor

@cee-chen cee-chen commented Oct 5, 2020

Summary

Since our other top level pages (settings, credentials, role mappings) aren't yet ready, we're reverting to the 7.9 UI for 7.10 (i.e., only showing the Engines Overview to users).

Screencaps

QA

  • Engines Overview looks functionally the same as 7.9
  • Setup Guide looks exactly the same as before

Checklist

Please note: this commit will immediately be reverted for 7.x/7.11 once the 7.10 branch is cut (tomorrow/FF). At that point, this PR should only exist in the 7.10 branch.

- Since our other top level pages (settings, credentials, role mappings) aren't yet ready, we'll stick to the same UI for 7.9, only showing the Engines Overview to users
@cee-chen cee-chen added Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Oct 5, 2020
@cee-chen cee-chen requested a review from a team October 5, 2020 16:58
@cee-chen
Copy link
Contributor Author

cee-chen commented Oct 5, 2020

@elastic/enterprise-search-frontend Pinging for an approval since this is a time-sensitive PR that needs to be merged in by EOD today. The follow-up PR reverting the change will not be time-sensitive. Thank you! 🙇‍♀️

Copy link
Contributor

@scottybollinger scottybollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cee-chen
Copy link
Contributor Author

cee-chen commented Oct 5, 2020

Thanks a bunch!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
enterpriseSearch 428.6KB 428.6KB +4.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen merged commit d5b8a95 into elastic:master Oct 5, 2020
@cee-chen cee-chen deleted the app-search-7.10 branch October 5, 2020 18:51
cee-chen pushed a commit that referenced this pull request Oct 5, 2020
…9506) (#79541)

- Since our other top level pages (settings, credentials, role mappings) aren't yet ready, we'll stick to the same UI for 7.9, only showing the Engines Overview to users
cee-chen pushed a commit that referenced this pull request Oct 6, 2020
@scottybollinger
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

ignoring request to update branch, pull request is closed

JasonStoltz pushed a commit to JasonStoltz/kibana that referenced this pull request Oct 6, 2020
cee-chen pushed a commit that referenced this pull request Oct 6, 2020
cee-chen pushed a commit that referenced this pull request Oct 8, 2020
…ease (#79506)" (#79702) (#79959)

This reverts commit d5b8a95.

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.10.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants