Skip to content

Conversation

@legrego
Copy link
Member

@legrego legrego commented Oct 2, 2020

Summary

Updates grunt to 1.3.0, and removes seemingly unused grunt-related packages

@legrego legrego added chore v7.10.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 2, 2020
@legrego legrego marked this pull request as ready for review October 2, 2020 19:05
@legrego
Copy link
Member Author

legrego commented Oct 2, 2020

@elastic/kibana-operations can I ask y'all for a review here? I removed some grunt modules which appear unused, and it didn't break anything locally for me, or in CI from what I can tell. I could be missing something though, so I don't want to merge this without you confirming that these aren't needed.

Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran a full build locally to be safe, didn't have any issues.

@legrego
Copy link
Member Author

legrego commented Nov 9, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
enterpriseSearch 664.5KB 664.5KB -21.0B

page load bundle size

id before after diff
upgradeAssistant 74.5KB 74.5KB -21.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@legrego legrego merged commit 55cf3bd into elastic:master Nov 9, 2020
@legrego legrego deleted the update-grunt branch November 9, 2020 16:33
@legrego legrego removed the v7.10.1 label Nov 9, 2020
legrego added a commit to legrego/kibana that referenced this pull request Nov 9, 2020
Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	yarn.lock
legrego added a commit that referenced this pull request Nov 9, 2020
Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	yarn.lock
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 10, 2020
* master: (39 commits)
  Fix ilm navigation (elastic#81664)
  [Lens] Distinct icons for XY and pie chart value labels toolbar (elastic#82927)
  [data.search.aggs] Throw an error when trying to create an agg type that doesn't exist. (elastic#81509)
  Index patterns api - load field list on server (elastic#82629)
  New events resolver (elastic#82170)
  [App Search] Misc naming tech debt (elastic#82770)
  load empty_kibana in test to have clean starting point (elastic#82772)
  Remove data <--> expressions circular dependencies. (elastic#82685)
  Update 8.0 breaking change template to gather information on how to programmatically detect it. (elastic#82905)
  Add alerting as codeowners to related documentation folder (elastic#82777)
  Add captions to user and space grid pages (elastic#82713)
  add alternate path for x-pack/Cloud test for Lens (elastic#82634)
  Uses asCurrentUser in getClusterUuid (elastic#82908)
  [Alerting][Connectors] Add new executor subaction to get 3rd party case fields (elastic#82519)
  Fix test import objects (elastic#82767)
  [ML] Add option for anomaly charts for metric detector should plot min, mean or max as appropriate (elastic#81662)
  Update alert type selection layout to rows instead of grid (elastic#73665)
  Prevent Kerberos and PKI providers from initiating a new session for unauthenticated XHR/API requests. (elastic#82817)
  Update grunt and related packages (elastic#79327)
  Allow the repository to search across all namespaces (elastic#82863)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants