Skip to content

Conversation

@jen-huang
Copy link
Contributor

@jen-huang jen-huang commented Oct 2, 2020

Summary

Follow up to #78699. This PR re-enables the test suites that were skipped in that PR.

This is currently expected to fail CI due to CI not being able to access the Docker image I switched the test to. However, this PR can be run locally to validate the tests.

To get the Endpoint package working while the updated package is not yet deployed, I added it manually under fixtures/test_packages. See commit a2d2eda. Once a public image is available, we should swap it out and revert that commit.

The only test suite that is failing locally after these changes are the Endpoint resolver tests: 4bfeba7.

Edit: I meant to open this PR as draft 😐 sorry for noise, folks!

@jen-huang jen-huang added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Management v7.10.0 Team:Fleet Team label for Observability Data Collection Fleet team labels Oct 2, 2020
@jen-huang jen-huang requested review from a team as code owners October 2, 2020 01:26
@jen-huang jen-huang self-assigned this Oct 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-management (Team:Endpoint Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@jen-huang jen-huang marked this pull request as draft October 2, 2020 01:27
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 2, 2020

💔 Build Failed

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jen-huang
Copy link
Contributor Author

Closing, superseded by #79290.

@jen-huang jen-huang closed this Oct 2, 2020
@jen-huang jen-huang deleted the ingest/reenable-tests branch October 2, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.10.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants