Panel Description Tooltip Design Change #79213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomThomson
added
Feature:Dashboard
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
cchaos
reviewed
Oct 1, 2020
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
Just a couple notes code-wise. But I think it was really smart to wrap the whole title in the tooltip so that it's easier to reach than just the tiny icon.
src/plugins/embeddable/public/lib/panel/panel_header/panel_header.tsx
Outdated
Show resolved
Hide resolved
src/plugins/embeddable/public/lib/panel/panel_header/panel_header.tsx
Outdated
Show resolved
Hide resolved
cchaos
approved these changes
Oct 1, 2020
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
Code and screenshots LGTM!
Contributor
💚 Build SucceededMetrics [docs]page load bundle size
History
To update your PR or re-run it, just comment with: |
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Oct 2, 2020
* wrapped Embeddable Panel title in EuiTooltip and centered description icon
ThomThomson
added a commit
that referenced
this pull request
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #79034
A small change to the design of the description tooltip - the tooltip now wraps the entire title, so it's easier to see the description. Additionally, the info icon is better vertically aligned with the panel title.
Before
After
After (Tooltip)
For maintainers