Skip to content

Conversation

@mistic
Copy link
Member

@mistic mistic commented Oct 1, 2020

That PR removes non existent plugin-path from the case api integration tests common configuration as after the introduction of #78973 running those tests endup in an error being thrown.

@mistic mistic added chore Team:Operations Kibana-Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.9.3 labels Oct 1, 2020
@mistic mistic requested a review from cnasikas October 1, 2020 14:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 574205d into elastic:master Oct 1, 2020
@mistic
Copy link
Member Author

mistic commented Oct 1, 2020

7.x: 48994b9
7.9: 5af8bfc

mistic added a commit to mistic/kibana that referenced this pull request Oct 1, 2020
… tests (elastic#79127)

* chore(NA): remove non existing plugin paths from case api integration tests config

* chore(NA): remove unused import
mistic added a commit to mistic/kibana that referenced this pull request Oct 1, 2020
… tests (elastic#79127)

* chore(NA): remove non existing plugin paths from case api integration tests config

* chore(NA): remove unused import
mistic added a commit that referenced this pull request Oct 1, 2020
… tests (#79127) (#79174)

* chore(NA): remove non existing plugin paths from case api integration tests config

* chore(NA): remove unused import
mistic added a commit that referenced this pull request Oct 1, 2020
… tests (#79127) (#79175)

* chore(NA): remove non existing plugin paths from case api integration tests config

* chore(NA): remove unused import
phillipb added a commit to phillipb/kibana that referenced this pull request Oct 1, 2020
…aly-detection-partition-field

* 'master' of github.com:elastic/kibana: (76 commits)
  Fix z-index of KQL Suggestions dropdown (elastic#79184)
  [babel] remove unused/unneeded babel plugins (elastic#79173)
  [Search] Fix timeout upgrade link (elastic#79045)
  Always Show Embeddable Panel Header in Edit Mode (elastic#79152)
  [Ingest]: add more test for transform index (elastic#79154)
  [ML] DF Analytics: Collapsable sections on results pages (elastic#76641)
  [Fleet] Fix agent policy change action migration (elastic#79046)
  [Ingest Manager] Match package spec `dataset`->`data_stream` and `config_templates`->`policy_templates` renaming (elastic#78699)
  Revert "[Metrics UI] Add ability to override datafeeds and job config for partition field (elastic#78875)"
  [ML] Update transform cloning to include description and new fields (elastic#78364)
  chore(NA): remove non existing plugin paths from case api integration tests (elastic#79127)
  [Ingest Manager] Ensure we trigger agent policy updated event when we bump revision. (elastic#78836)
  [Metrics UI] Display No Data context.values as [NO DATA] (elastic#78038)
  [Monitoring] Missing data alert (elastic#78208)
  [Lens] Fix embeddable title and description for reporting and dashboard tooltip (elastic#78767)
  [Lens] Consistent Drag and Drop styles (elastic#78674)
  [ML] Model management UI fixes and enhancements (elastic#79072)
  [Metrics UI] Add ability to override datafeeds and job config for partition field (elastic#78875)
  [Security Solution]Fix basepath used by endpoint telemetry tests (elastic#79027)
  update rum agent version which contains longtasks (elastic#79105)
  ...
rylnd added a commit to rylnd/kibana that referenced this pull request Dec 4, 2020
These paths (or rather their absence) breaks the functional_tests_server script.

An analogous problem for cases was fixed in elastic#79127.
rylnd added a commit that referenced this pull request Dec 4, 2020
* Remove nonexistent paths from our API tests config

These paths (or rather their absence) breaks the functional_tests_server script.

An analogous problem for cases was fixed in #79127.

* Remove duplicated context from logger

This context is already provided to the logger by kibana; adding it a
second time leads to duplicated log tags, e.g.:

```
server    log   [12:36:07.138] [debug][plugins][plugins][securitySolution][securitySolution] ...
```

This is now fixed:

```
server    log   [12:41:52.112] [debug][plugins][securitySolution] ...
```
rylnd added a commit that referenced this pull request Dec 5, 2020
* Remove nonexistent paths from our API tests config

These paths (or rather their absence) breaks the functional_tests_server script.

An analogous problem for cases was fixed in #79127.

* Remove duplicated context from logger

This context is already provided to the logger by kibana; adding it a
second time leads to duplicated log tags, e.g.:

```
server    log   [12:36:07.138] [debug][plugins][plugins][securitySolution][securitySolution] ...
```

This is now fixed:

```
server    log   [12:41:52.112] [debug][plugins][securitySolution] ...
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.9.3 v7.10.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants