[Discover] Refactor discover.js controller topnav code #79062
Conversation
…-01-discover-refactor-topnav-code
|
@elasticmachine merge upstream |
…github.com:kertal/kibana into kertal-pr-2020-10-01-discover-refactor-topnav-code
…-01-discover-refactor-topnav-code
| import { updateSearchSource } from '../helpers/update_search_source'; | ||
| import { calcFieldCounts } from '../helpers/calc_field_counts'; | ||
|
|
||
| const services = getServices(); |
There was a problem hiding this comment.
Note that the IDE did some of this reorderings, import before variable declaration, sort import alphabetical, kept it because they make sense
| stateValFound: !!index && id === index, | ||
| }); | ||
| }), | ||
| ip: loadIndexPattern(index, data.indexPatterns, config), |
There was a problem hiding this comment.
Note that the refactoring here is a first step, separate loading and resolving shouldn't be necessary, it improving it step by step
majagrubic
left a comment
majagrubic
left a comment
There was a problem hiding this comment.
I had another pass through this, both the code and a round of testing, and I don't have any major concerns around merging this. Let me know if you want to do some improvements to the code, and then I can approve 👍
thx for diving in! 🌊 I will address your comments today! |
| removeField<K extends keyof SearchSourceFields>(field: K) { | ||
| delete this.fields[field]; | ||
| return this; | ||
| } |
There was a problem hiding this comment.
Why did I add this? To prevent TypeScript confusion, because when I used 'setFields(key, null)' to remove it, I got depending what I was trying to remove TypeScript errors
There was a problem hiding this comment.
Would be nice if we could add a quick unit test for the new method
There was a problem hiding this comment.
Absolutely! I've added a jest test.
…-01-discover-refactor-topnav-code
lukeelmers
left a comment
lukeelmers
left a comment
There was a problem hiding this comment.
Just looked at app services code -- The searchSource.removeField update makes sense to me 👍
@majagrubic from my side it should be fine, let me know if there's something else I should do |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
…github.com:kertal/kibana into kertal-pr-2020-10-01-discover-refactor-topnav-code
|
@elasticmachine merge upstream |
majagrubic
left a comment
majagrubic
left a comment
There was a problem hiding this comment.
I haven't tested it since the last revision, but code changes look good 👍
…github.com:kertal/kibana into kertal-pr-2020-10-01-discover-refactor-topnav-code
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
* Move discover.js functions to helper functions in separate files * Convert to TypeScript * Add unit tests * Add removeField function to SearchSource
6 participants
Summary
This PR extracts logic & functionality of discover.js (containing the angular controller) related to the topnav/toolbar, field counting, search source updating to separate files and functions, converting to TypeScript.
Testing
There shall be no regressions!
Checklist