Skip to content

[Search] Fix timeout upgrade link #79045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2020
Merged

[Search] Fix timeout upgrade link #79045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/plugins/data/public/search/errors/timeout_error.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ describe('SearchTimeoutError', () => {

expect(component.find('EuiButton').length).toBe(1);
component.find('EuiButton').simulate('click');
expect(startMock.application.navigateToApp).toHaveBeenCalledWith('management', {
path: '/kibana/indexPatterns',
});
expect(startMock.application.navigateToUrl).toHaveBeenCalledWith(
'https://www.elastic.co/subscriptions'
);
});

it('Should create contact admin message', () => {
Expand Down
4 changes: 1 addition & 3 deletions src/plugins/data/public/search/errors/timeout_error.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,7 @@ export class SearchTimeoutError extends KbnError {
private onClick(application: ApplicationStart) {
switch (this.mode) {
case TimeoutErrorMode.UPGRADE:
application.navigateToApp('management', {
path: `/kibana/indexPatterns`,
});
application.navigateToUrl('https://www.elastic.co/subscriptions');
Copy link
Contributor

@lizozom lizozom Oct 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue states that the redirect should go elsewhere on cloud. Is it possible?

#70376

Copy link
Contributor Author

@lukasolson lukasolson Oct 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the linked issue:

I don't consider it a priority issue but logging it for tracking.

I think it's on the radar that having a generalized service for this is getting more and more important, but I don't feel like it's our realm of responsibility to provide this in this issue.

break;
case TimeoutErrorMode.CHANGE:
application.navigateToApp('management', {
Expand Down