Skip to content

move apps lower in tree, add metricbeat dashboard screenshot test #79001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2020
Merged

move apps lower in tree, add metricbeat dashboard screenshot test #79001

merged 2 commits into from
Oct 1, 2020

Conversation

@LeeDr
Copy link

@LeeDr LeeDr commented Sep 30, 2020

Summary

  1. moved tests from;
    x-pack/test/stack_functional_integration/test/functional/apps/
    to
    x-pack/test/stack_functional_integration/apps/

  2. created new _metricbeat_dashboard test in x-pack/test/stack_functional_integration/apps/metricbeat. This new test required some additional changes;

    1. It's a visual regression screenshot test using the existing screenshot.compareAgainstBaseline() function. But we don't want to add binary png images to the already large Kibana repo, so the config file for these tests sets the screenshots folder to the integration-test repo since that's what starts these tests.
    2. It's the first stack_functional_integration test to use esArchiver and since those archives could be large, I thought I would follow the pattern above and store those in the integration-test repo as well

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@LeeDr LeeDr requested a review from a team as a code owner September 30, 2020 17:44
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 1, 2020

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@LeeDr LeeDr added test-stack-integration v7.10.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:QA Platform QA t// labels Oct 1, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 1, 2020

Pinging @elastic/kibana-qa (Team:QA)

@LeeDr LeeDr merged commit 0a7462d into elastic:master Oct 1, 2020
@LeeDr LeeDr deleted the stackMetricbeatScreenshot branch October 1, 2020 20:35
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 5, 2020
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 5, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79001 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 6, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79001 or prevent reminders by adding the backport:skip label.

@LeeDr
Copy link
Author

LeeDr commented Oct 6, 2020

NOTE: I'm waiting for a good run of integration-test on master before backporting this.

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 7, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79001 or prevent reminders by adding the backport:skip label.

8 similar comments
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 8, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79001 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 9, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79001 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 12, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79001 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 13, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79001 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 14, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79001 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 15, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79001 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 16, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79001 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 19, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79001 or prevent reminders by adding the backport:skip label.

@marius-dr marius-dr added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Oct 20, 2020
@LeeDr LeeDr mentioned this pull request Oct 27, 2020
Merged
LeeDr pushed a commit to LeeDr/kibana that referenced this pull request Oct 27, 2020
move apps lower in tree, add metricbeat dashboard screenshot test (el…
9be2025 
…astic#79001)
@LeeDr LeeDr mentioned this pull request Oct 27, 2020
Merged
LeeDr pushed a commit that referenced this pull request Oct 27, 2020
[7.x] move apps lower in tree, add metricbeat dashboard screenshot te…
a2b4067 
…st (#79001) (#81851)
@LeeDr LeeDr removed the backport:skip This PR does not require backporting label Oct 28, 2020
LeeDr pushed a commit that referenced this pull request Oct 28, 2020
@kibanamachine
[7.10] move apps lower in tree, add metricbeat dashboard screenshot t…
e28814c 
…est (#79001) (#81852)

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marius-dr marius-dr Awaiting requested review from marius-dr

1 more reviewer

@wayneseymour wayneseymour wayneseymour approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:QA Platform QA t// test-stack-integration v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LeeDr @kibanamachine @elasticmachine @wayneseymour @marius-dr