Skip to content

[backport] PR #7873 to 4.1#7877

Merged
jbudz merged 1 commit intoelastic:4.1from
jbudz:typeahead-4.1
Jul 28, 2016
Merged

[backport] PR #7873 to 4.1#7877
jbudz merged 1 commit intoelastic:4.1from
jbudz:typeahead-4.1

Conversation

@jbudz
Copy link
Contributor

@jbudz jbudz commented Jul 28, 2016

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you included unit tests that cover the changes?
  • If submitting code, have you tested and built your code locally prior to submission with npm test && npm run build?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.

@jbudz jbudz added the backport This PR is a backport of another PR label Jul 28, 2016
@jbudz jbudz self-assigned this Jul 28, 2016
@epixa
Copy link
Contributor

epixa commented Jul 28, 2016

Seriously though, have you signed the contributor license agreement? Have you followed the contributor guidelines?

@jbudz
Copy link
Contributor Author

jbudz commented Jul 28, 2016

Whoops my pull request isn't against master, I'm not doing the last bullet point right

@epixa
Copy link
Contributor

epixa commented Jul 28, 2016

Cut it out

@jbudz jbudz merged commit b2fb6cb into elastic:4.1 Jul 28, 2016
@jbudz jbudz deleted the typeahead-4.1 branch July 28, 2016 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants