load apm-rum agent lazily #78760
Merged
load apm-rum agent lazily #78760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
Team:Core
Contributor
|
Pinging @elastic/kibana-platform (Team:Platform) |
mshustov
commented
Sep 29, 2020
src/core/public/kbn_bootstrap.ts
Outdated
| init(apmConfig); | ||
| let i18nError: Error | undefined; | ||
| try { | ||
| await i18n.load(injectedMetadata.i18n.translationsUrl); |
Contributor
Author
There was a problem hiding this comment.
we can run i18n and apm-agent loading in parallel, but I don't think an error during '@elastic/apm-rum' loading should lead to a global error as i18n does. btw should we mute an error for '@elastic/apm-rum' failed loading?
Contributor
There was a problem hiding this comment.
Parallel makes sense 👍 Could we also call coreSystem.setup in parallel? I suspect there may be an implicit dependency that the i18n module is initialized before setup, so maybe not.
Agreed, any errors from APM configuration should not block starting up Kibana. I think logging a warning would be nice for debugging purposes.
Contributor
Author
There was a problem hiding this comment.
Parallel makes sense
@joshdover added. PTAL.
Could we also call coreSystem.setup in parallel
We shouldn't as we may want to instrument setup with apm agent.
joshdover
approved these changes
Sep 29, 2020
Comment on lines
+20
to
+26
| /** | ||
| * This is the entry point used to boot the frontend when serving a application | ||
| * that lives in the Kibana Platform. | ||
| * | ||
| * Any changes to this file should be kept in sync with | ||
| * src/legacy/ui/ui_bundles/app_entry_template.js | ||
| */ |
Contributor
There was a problem hiding this comment.
I believe this comment can be deleted
pgayvallet
approved these changes
Sep 29, 2020
Contributor
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
distributable file count
page load bundle size
History
To update your PR or re-run it, just comment with: |
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Sep 30, 2020
* load apm-agent-lazily * update docs * remove outdated comment * add test
mshustov
added a commit
that referenced
this pull request
Sep 30, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 30, 2020
* master: (97 commits) [Actions] Adds a "Test Connector" button on the Connectors List to make discovery of the Test tab easier (elastic#78746) [Discover] Fix functional time picker test permissions (elastic#78564) [ML] Fixing module datafeed overrides (elastic#78925) Adds some missing licenses to the CSV export (elastic#78719) [dev/cli] ensure plugins/ and all watch source dirs exist (elastic#78973) [Lens] Stop using scripted metric to collect telemetry (elastic#78687) [Lens] fix wrong message in fields accordion (elastic#78924) [Enterprise Search][App Search] Credentials Logic updates (elastic#78644) [Monitoring] Disk usage alerting (elastic#75419) [SECURITY_SOLUTION] Trusted apps list expand/collapse details (elastic#78601) Update content on interstitial page (elastic#78881) chore(NA): include hjson as a prod dependency (elastic#78941) Fix empty meta fields input in Advanced Settings (elastic#78576) [Lens] Maintain order of operations in dimension panel (elastic#78864) Fix plugin doc title (elastic#78880) load apm-rum agent lazily (elastic#78760) [ML] Skip full ML access permission test Optimize charts plugin (elastic#78922) ui_actions service initial docs (elastic#78902) skip failing suite (elastic#78942) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Platform inits
@elastic/apm-rumonly if apm agent is configured. We can load the library lazily only when necessary.Reduces the
core.entry.jsfile size from 790Kb to 611Kb.