Skip to content

Conversation

@nreese
Copy link
Contributor

@nreese nreese commented Sep 28, 2020

Backports the following commits to 7.x:

…astic#77683)

* Add deprecation message to coordinate map and region map

* clean up text

* add default distro link and view in maps link

* move url generation into onClick handler

* create tile map layer descritor

* set metrics and color and scaling

* lazy load createTileMapLayerDescriptor

* tslint fixes

* tslint cleanup for OSS code

* add region map deprecation message

* tslint cleanup

* consolidate logic into LegacyMapDeprecationMessage

* fix jest test

* fix tile-map and region_map in OSS distro

* tslint fixes

* assert urlGenerator exists

* update message text

* ensure legacy-ids get correctly evaluated (#37)

* handle 6.x region map saved objects

* turn off field meta

* fix type

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Thomas Neirynck <[email protected]>
# Conflicts:
#	src/plugins/visualizations/public/vis_types/base_vis_type.ts
@nreese nreese added the backport This PR is a backport of another PR label Sep 28, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id value diff baseline
maps 738 +2 736
mapsLegacy 186 +1 185
regionMap 15 +1 14
tileMap 21 +1 20
total +5

async chunks size

id value diff baseline
maps 3.3MB +8.5KB 3.3MB
mapsLegacy 731.3KB +1.0B 731.3KB
visualize 272.1KB +711.0B 271.4KB
total +9.2KB

page load bundle size

id value diff baseline
maps 164.4KB +5.6KB 158.8KB
mapsLegacy 99.6KB +3.1KB 96.5KB
regionMap 49.9KB +5.0KB 44.9KB
tileMap 49.1KB +4.2KB 44.9KB
visualizations 273.6KB +194.0B 273.4KB
total +18.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit e01bab8 into elastic:7.x Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants