Conversation
|
LGTM. Probably out of scope for this PR but I'd like to rework this section holistically:
Into something simpler like this:
I can put up a separate PR for my proposed change. |
|
@ycombinator Do it! |
CONTRIBUTING.md
Outdated
|
|
||
| #### My issue isn't getting enough attention | ||
| First of all, sorry about that, we want you to have a great time with Kibana! You should join us on IRC ([#kibana](https://kiwiirc.com/client/irc.freenode.net/?#kibana) on freenode) and chat about it. Github is terrible for conversations. With that out of the way, there are a number of variables that go into deciding what to work on. These include priority, impact, difficulty, applicability to use cases, and last, and importantly: What we feel like working on. | ||
| First of all, sorry about that, we want you to have a great time with Kibana! You should join us on IRC ([#kibana](https://kiwiirc.com/client/irc.freenode.net/?#kibana) on freenode) and chat about it. GitHub is terrible for conversations. With that out of the way, there are a number of variables that go into deciding what to work on. These include priority, impact, difficulty, applicability to use cases, and last, and importantly: What we feel like working on. |
There was a problem hiding this comment.
Maybe replace everything from "GitHub is terrible for conversations" onwards with just:
We prioritize issues according to impact and difficulty, so some issues can continually be overshadowed as more pressing issues arise.
I feel like "we work on what we feel like working on" sounds kind of juvenile, and also inaccurate. Thoughts?
There was a problem hiding this comment.
Agreed, definitely childish tone to it and kind of unapologetically "not our problem"
|
LGTM! Just 1 idea. |
|
Great work! LGTM. |
|
@cjcenizal Could you do a second pass? 🎉 |
|
Looks good but the number of commits doesn't seem reflected in the diff. |
|
@cjcenizal Of course. Now just one commit :) |
|
Great improvements! LGTM. |
CONTRIBUTING.md
Outdated
There was a problem hiding this comment.
How do you feel about explicitly saying "use issue reactions for +1s, don't write comments with just a +1"? I'd like this section to focus even more on encouraging well written, thoughtful comments. I'd suggest something like this:
"If an issue is important to you, add a comment with a solid write up of your use case and an explanation of why it's so important. Don't just comment with a 👍 . We seriously appreciate thoughtful comments. By sharing your thoughts we might even be able to come up with creative alternative solutions for your specific problem. If everything you'd like to say has already been said but you'd like to add a token of support, feel free to use the 👍 reaction on the issue itself and the comment which best summarizes your thoughts."
|
LGTM |
|
LGTM |
|
Courté |
Made the contributing guidelines a little more inviting by adding a table of contents and updating some of the wording to be more friendly and less about "this is how we do things".