Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding title to x_axis labels #7845

Merged
merged 3 commits into from
Aug 2, 2016
Merged

adding title to x_axis labels #7845

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8e47e9
adding title to x_axis labels
ppisljar Jul 26, 2016
fcee021
updating indentation
ppisljar Jul 27, 2016
fad350e
updating style
ppisljar Jul 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/ui/public/vislib/lib/x_axis.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ export default function XAxisFactory(Private) {
let self = this;
let text;
let barWidth = self.xScale.rangeBand();
let maxRotatedLength = 180;
let maxRotatedLength = 120;
let xAxisPadding = 15;
let svg;
let lengths = [];
Expand Down Expand Up @@ -351,7 +351,11 @@ export default function XAxisFactory(Private) {
.attr('dy', '-.60em')
.attr('transform', function rotate() {
return 'rotate(-90)';
});
})
.append('title')
.text(function () {
return this.__data__;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My d3 is a little rusty, but I'm not sure data is the most appropriate way to access the text here. Won't the first parameter passed to this function contain the text you need?

Also, indentation needs fixed.

});
selection.select('svg')
.attr('height', self._attr.xAxisLabelHt);
}
Expand Down